You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/11/21 19:40:36 UTC

Review Request 28338: HDP-UTILS repo URL reverts to default on ambari-server restart (trunk fix and unit tests)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28338/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and John Speidel.


Bugs: AMBARI-8321
    https://issues.apache.org/jira/browse/AMBARI-8321


Repository: ambari


Description
-------

Same as AMBARI-8319, but for trunk and add unit tests.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4b78216 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 5d1d098 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 20dba84 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 136e8a8 

Diff: https://reviews.apache.org/r/28338/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [3.184s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.477s]
[INFO] Ambari Web ........................................ SUCCESS [39.229s]
[INFO] Ambari Views ...................................... SUCCESS [4.208s]
[INFO] Ambari Admin View ................................. SUCCESS [11.066s]
[INFO] Ambari Server ..................................... SUCCESS [20:20.869s]
[INFO] Ambari Agent ...................................... SUCCESS [6.205s]
[INFO] Ambari Client ..................................... SUCCESS [0.038s]
[INFO] Ambari Python Client .............................. SUCCESS [0.257s]
[INFO] Ambari Groovy Client .............................. SUCCESS [9.891s]
[INFO] Ambari Shell ...................................... SUCCESS [0.030s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.034s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [6.533s]


Thanks,

Dmytro Sen


Re: Review Request 28338: HDP-UTILS repo URL reverts to default on ambari-server restart (trunk fix and unit tests)

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28338/#review62593
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 21, 2014, 6:40 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28338/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 6:40 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and John Speidel.
> 
> 
> Bugs: AMBARI-8321
>     https://issues.apache.org/jira/browse/AMBARI-8321
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Same as AMBARI-8319, but for trunk and add unit tests.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4b78216 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 5d1d098 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 20dba84 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 136e8a8 
> 
> Diff: https://reviews.apache.org/r/28338/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.184s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.477s]
> [INFO] Ambari Web ........................................ SUCCESS [39.229s]
> [INFO] Ambari Views ...................................... SUCCESS [4.208s]
> [INFO] Ambari Admin View ................................. SUCCESS [11.066s]
> [INFO] Ambari Server ..................................... SUCCESS [20:20.869s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.205s]
> [INFO] Ambari Client ..................................... SUCCESS [0.038s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.257s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [9.891s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.030s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.034s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.533s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 28338: HDP-UTILS repo URL reverts to default on ambari-server restart (trunk fix and unit tests)

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28338/
-----------------------------------------------------------

(Updated Дек. 5, 2014, 12:08 п.п.)


Review request for Ambari, Dmitro Lisnichenko and John Speidel.


Bugs: AMBARI-8321
    https://issues.apache.org/jira/browse/AMBARI-8321


Repository: ambari


Description
-------

Same as AMBARI-8319, but for trunk and add unit tests.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4b78216 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 5d1d098 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 20dba84 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8a4e627 

Diff: https://reviews.apache.org/r/28338/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [3.184s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.477s]
[INFO] Ambari Web ........................................ SUCCESS [39.229s]
[INFO] Ambari Views ...................................... SUCCESS [4.208s]
[INFO] Ambari Admin View ................................. SUCCESS [11.066s]
[INFO] Ambari Server ..................................... SUCCESS [20:20.869s]
[INFO] Ambari Agent ...................................... SUCCESS [6.205s]
[INFO] Ambari Client ..................................... SUCCESS [0.038s]
[INFO] Ambari Python Client .............................. SUCCESS [0.257s]
[INFO] Ambari Groovy Client .............................. SUCCESS [9.891s]
[INFO] Ambari Shell ...................................... SUCCESS [0.030s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.034s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [6.533s]


Thanks,

Dmytro Sen


Re: Review Request 28338: HDP-UTILS repo URL reverts to default on ambari-server restart (trunk fix and unit tests)

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28338/#review63895
-----------------------------------------------------------

Ship it!


Ship It!


ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
<https://reviews.apache.org/r/28338/#comment106208>

    minor nit, please fix the vertical alignment of the param description


- John Speidel


On Nov. 21, 2014, 6:40 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28338/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 6:40 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and John Speidel.
> 
> 
> Bugs: AMBARI-8321
>     https://issues.apache.org/jira/browse/AMBARI-8321
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Same as AMBARI-8319, but for trunk and add unit tests.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4b78216 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 5d1d098 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 20dba84 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 136e8a8 
> 
> Diff: https://reviews.apache.org/r/28338/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.184s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.477s]
> [INFO] Ambari Web ........................................ SUCCESS [39.229s]
> [INFO] Ambari Views ...................................... SUCCESS [4.208s]
> [INFO] Ambari Admin View ................................. SUCCESS [11.066s]
> [INFO] Ambari Server ..................................... SUCCESS [20:20.869s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.205s]
> [INFO] Ambari Client ..................................... SUCCESS [0.038s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.257s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [9.891s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.030s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.034s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.533s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>