[GitHub] [spark] HyukjinKwon commented on a change in pull request #33876: [SPARK-36626][PYTHON] Support TimestampNTZ in createDataFrame/toPandas and Python UDFs

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #33876:
URL: https://github.com/apache/spark/pull/33876#discussion_r699814247



##########
File path: python/pyspark/sql/pandas/conversion.py
##########
@@ -336,10 +338,12 @@ def createDataFrame(self, data, schema=None, samplingRatio=None, verifySchema=Tr
                         "has been set to false.\n  %s" % str(e))
                     warnings.warn(msg)
                     raise
-        data = self._convert_from_pandas(data, schema, timezone)
+
+        should_localize = not self._is_timestamp_ntz_preferred()

Review comment:
       I think I called it here to make `_convert_from_pandas` indenependent from `SparkSession`. `_convert_from_pandas` doesn't have any reference of `self` ... but looks like I overthought too much ... let me call it there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org