[jira] Resolved: (SHINDIG-1140) Add "set" functionality for the Config class

["Chris Chabot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-1140.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1-BETA2
         Assignee: Chris Chabot

LGTM, patch's been committed

> Add "set" functionality for the Config class
> --------------------------------------------
>
>                 Key: SHINDIG-1140
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1140
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>            Reporter: Arne Roomann-Kurrik
>            Assignee: Chris Chabot
>            Priority: Trivial
>             Fix For: 1.1-BETA2
>
>         Attachments: issue101042_1.diff
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> The Config class allows for the custom injection of classes into a deployed version of PHP Shindig, but does not support overriding certain values for the purposes of injecting mock objects into a unit test environment.  
> I'll be attaching a patch which adds a set function to Config, allowing unit tests to temporarily override a specific configuration value.  A code review may be found here: http://codereview.appspot.com/101042

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.