You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/20 23:48:00 UTC
[GitHub] dbtsai edited a comment on issue #23343: [SPARK-26390][SQL]
ColumnPruning rule should only do column pruning
dbtsai edited a comment on issue #23343: [SPARK-26390][SQL] ColumnPruning rule should only do column pruning
URL: https://github.com/apache/spark/pull/23343#issuecomment-449178914
@gatorsmile for example, we were refactoring `ReplaceNullWithFalseInPredicate` out from `expressions.scala` as it grows too big, https://github.com/apache/spark/pull/23139/.
I'm wondering when we should or should not do such refactoring. I create a PR https://github.com/apache/spark/pull/23359 so we can discuss over there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org