You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HHoflittlefish777 (via GitHub)" <gi...@apache.org> on 2024/03/15 03:42:50 UTC
[PR] [fix](load) fix load channel may memory leak [doris]
HHoflittlefish777 opened a new pull request, #32277:
URL: https://github.com/apache/doris/pull/32277
## Proposed changes
load channel resource can not be recycled, causing memory leak.
Bug would be happened in follow corn case:
- use group commit and fragment open fail.
- load empty file with fail.
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32277:
URL: https://github.com/apache/doris/pull/32277#issuecomment-1998927148
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32277:
URL: https://github.com/apache/doris/pull/32277#issuecomment-1998888664
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32277:
URL: https://github.com/apache/doris/pull/32277#issuecomment-1998884186
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32277:
URL: https://github.com/apache/doris/pull/32277#issuecomment-1998927113
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #32277:
URL: https://github.com/apache/doris/pull/32277#issuecomment-1998884414
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32277:
URL: https://github.com/apache/doris/pull/32277#issuecomment-1998895920
<details>
<summary>TPC-H: <b>Total hot run time: 38141 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 331b031a8e2510c88b10866db0fbe23ce2d8f02a, data reload: false
------ Round 1 ----------------------------------
q1 17675 4286 4102 4102
q2 2024 158 146 146
q3 10661 1090 896 896
q4 7436 715 699 699
q5 7462 2691 2541 2541
q6 187 123 121 121
q7 1218 810 795 795
q8 9355 2035 2023 2023
q9 7056 6464 6421 6421
q10 8445 3550 3658 3550
q11 427 224 213 213
q12 653 294 300 294
q13 17789 2859 2836 2836
q14 280 251 260 251
q15 515 448 445 445
q16 479 390 388 388
q17 957 532 584 532
q18 8208 6620 6371 6371
q19 1529 1480 1383 1383
q20 575 291 287 287
q21 6218 3559 3548 3548
q22 340 318 299 299
Total cold run time: 109489 ms
Total hot run time: 38141 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4090 4082 4035 4035
q2 319 224 230 224
q3 2939 2844 2817 2817
q4 1804 1561 1560 1560
q5 5212 5270 5295 5270
q6 189 116 117 116
q7 2250 1858 1864 1858
q8 3150 3309 3324 3309
q9 8600 8591 8574 8574
q10 3720 3698 3660 3660
q11 536 432 436 432
q12 714 555 553 553
q13 16886 2836 2848 2836
q14 279 254 267 254
q15 484 435 444 435
q16 456 390 403 390
q17 1749 1476 1462 1462
q18 7588 7213 7104 7104
q19 1613 1564 1572 1564
q20 1905 1716 1693 1693
q21 4800 4578 4856 4578
q22 531 464 454 454
Total cold run time: 69814 ms
Total hot run time: 53178 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32277:
URL: https://github.com/apache/doris/pull/32277#issuecomment-1998902191
TeamCity be ut coverage result:
Function Coverage: 34.95% (8574/24531)
Line Coverage: 26.66% (69479/260586)
Region Coverage: 25.95% (36088/139046)
Branch Coverage: 22.91% (18427/80434)
Coverage Report: http://coverage.selectdb-in.cc/coverage/331b031a8e2510c88b10866db0fbe23ce2d8f02a_331b031a8e2510c88b10866db0fbe23ce2d8f02a/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix load channel may memory leak [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32277:
URL: https://github.com/apache/doris/pull/32277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org