[jira] [Work logged] (HIVE-24909) Skip the repl events from getting logged in notification log

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-24909?focusedWorklogId=594743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594743 ]

ASF GitHub Bot logged work on HIVE-24909:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/21 19:31
            Start Date: 11/May/21 19:31
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r630392694



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -584,6 +600,7 @@ public void rollbackTxn() throws LockException {
           e);
     } finally {
       resetTxnInfo();
+      replPolicy = null;

Review comment:
       same here

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Context.java
##########
@@ -123,6 +123,8 @@
   // up when we are done.
   private final Set<Context> subContexts;
 
+  private String replPolicy = null;

Review comment:
       nit: default would be null only. 

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -539,12 +550,13 @@ public void commitTxn() throws LockException {
     } finally {
       // do all new reset in resetTxnInfo method to make sure that same code is there for replCommitTxn flow.
       resetTxnInfo();
+      replPolicy = null;

Review comment:
       Why not to move this to resetTxnInfo(). All the clean up is anyway there




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 594743)
    Time Spent: 7h  (was: 6h 50m)

> Skip the repl events from getting logged in notification log
> ------------------------------------------------------------
>
>                 Key: HIVE-24909
>                 URL: https://issues.apache.org/jira/browse/HIVE-24909
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Haymant Mangla
>            Assignee: Haymant Mangla
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 7h
>  Remaining Estimate: 0h
>
> Currently REPL dump events are logged and replicated as a part of replication policy. Whenever one replication cycle completed, we always have one transaction left open on the target corresponding to repl dump operation. This will never be caught up without manually dealing with the transaction on target cluster.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)