[GitHub] [iceberg] SinghAsDev edited a comment on pull request #4018: [HiveCatalog] Make Hive's external table behavior match with Iceberg table's gc.enabled behavior.

[GitBox <gi...@apache.org>]

SinghAsDev edited a comment on pull request #4018:
URL: https://github.com/apache/iceberg/pull/4018#issuecomment-1027165582


   Hi @marton-bod , thanks for the comment. A few follow ups.
   
   1. What you said is definitely correct that we translate `gc.enabled` behavior to hive's `external.table.purge` behavior while creating hms table in hive catalog. However, the issue I am pointing to is that `external` table behavior is not translated to `gc.enabled` behavior. The issue should be evident from unit tests added in this PR, but let me also add a bit of clarification to the PR summary.
   2. `external.table.purge` is only supported for >= Hive 4.x.
   3. I think I should update the diff to also check for `external.table.purge` property before turning on/off gc.enabled. What do you think @marton-bod ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org