[GitHub] [kafka] ijuma commented on a change in pull request #8449: KAFKA-7613: Enable -Xlint:try, fixing warnings

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #8449:
URL: https://github.com/apache/kafka/pull/8449#discussion_r413573833



##########
File path: clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##########
@@ -32,6 +32,7 @@
  * using the default constructor and will then pass the broker configs to its <code>configure()</code> method. During
  * broker shutdown, the <code>close()</code> method will be invoked so that resources can be released (if necessary).
  */
+@SuppressWarnings("try") // can't override close() to now declare throws Exception until Kafka 3.0

Review comment:
       Why would we want to override `close()` to throw `Exception` if that's what it does already?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org