You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2016/08/25 09:20:22 UTC

Review Request 51423: LENS-1289 : Fact column start_time and end_time not getting reflected with update fact command

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51423/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1289
    https://issues.apache.org/jira/browse/LENS-1289


Repository: lens


Description
-------

With update fact table command, start and end time properties for columns will be added.


Diffs
-----

  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 9670d8f 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0dce6c4 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 62c7ec9 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 31b8ce4 

Diff: https://reviews.apache.org/r/51423/diff/


Testing
-------

Added test to validate, mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.417s]
[INFO] Lens .............................................. SUCCESS [4.545s]
[INFO] Lens API .......................................... SUCCESS [26.527s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.325s]
[INFO] Lens Cube ......................................... SUCCESS [14:44.332s]
[INFO] Lens DB storage ................................... SUCCESS [17.287s]
[INFO] Lens Query Library ................................ SUCCESS [13.669s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:21.392s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.758s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [20.517s]
[INFO] Lens Server ....................................... SUCCESS [13:52.089s]
[INFO] Lens client ....................................... SUCCESS [1:30.070s]
[INFO] Lens CLI .......................................... SUCCESS [1:17.994s]
[INFO] Lens Examples ..................................... SUCCESS [7.231s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.682s]
[INFO] Lens Distribution ................................. SUCCESS [9.638s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:07.614s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.120s]
[INFO] Lens Regression ................................... SUCCESS [11.067s]
[INFO] Lens UI ........................................... SUCCESS [30.535s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37:17.758s
[INFO] Finished at: Thu Aug 25 09:13:29 UTC 2016
[INFO] Final Memory: 181M/1960M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty


Re: Review Request 51423: LENS-1289 : Fact column start_time and end_time not getting reflected with update fact command

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51423/#review146772
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On Aug. 25, 2016, 2:50 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51423/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 2:50 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1289
>     https://issues.apache.org/jira/browse/LENS-1289
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> With update fact table command, start and end time properties for columns will be added.
> 
> 
> Diffs
> -----
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 9670d8f 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0dce6c4 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 62c7ec9 
>   lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 31b8ce4 
> 
> Diff: https://reviews.apache.org/r/51423/diff/
> 
> 
> Testing
> -------
> 
> Added test to validate, mvn clean install runs fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.417s]
> [INFO] Lens .............................................. SUCCESS [4.545s]
> [INFO] Lens API .......................................... SUCCESS [26.527s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.325s]
> [INFO] Lens Cube ......................................... SUCCESS [14:44.332s]
> [INFO] Lens DB storage ................................... SUCCESS [17.287s]
> [INFO] Lens Query Library ................................ SUCCESS [13.669s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.392s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.758s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.517s]
> [INFO] Lens Server ....................................... SUCCESS [13:52.089s]
> [INFO] Lens client ....................................... SUCCESS [1:30.070s]
> [INFO] Lens CLI .......................................... SUCCESS [1:17.994s]
> [INFO] Lens Examples ..................................... SUCCESS [7.231s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.682s]
> [INFO] Lens Distribution ................................. SUCCESS [9.638s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:07.614s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.120s]
> [INFO] Lens Regression ................................... SUCCESS [11.067s]
> [INFO] Lens UI ........................................... SUCCESS [30.535s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 37:17.758s
> [INFO] Finished at: Thu Aug 25 09:13:29 UTC 2016
> [INFO] Final Memory: 181M/1960M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>