You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org> on 2024/03/06 21:09:57 UTC

Re: [PR] CASSANDRA-19185 Use glove vectors instead of random vectors in vector tests [cassandra]

ekaterinadimitrova2 commented on code in PR #3151:
URL: https://github.com/apache/cassandra/pull/3151#discussion_r1515139272


##########
test/distributed/org/apache/cassandra/distributed/test/sai/VectorDistributedTest.java:
##########
@@ -74,11 +75,13 @@ public class VectorDistributedTest extends TestBaseImpl
 
     private static Cluster cluster;
 
-    private static int dimensionCount;
+    protected static Glove.WordVector word2vec;
 
     @BeforeClass
     public static void setupCluster() throws Exception
     {
+        word2vec = Glove.parse(VectorDistributedTest.class.getClassLoader().getResourceAsStream("glove.3K.50d.txt"));
+

Review Comment:
   I noticed that we set the `MemtableAllocationType` to `offheap_objects` here; Cassandra, by default, uses `memtable_allocation_type: heap_buffers`. Recently, we noticed in `test/conf/cassandra.yaml `that we were testing with `offheap_objects`, and we switched to the `heap_buffers`, the config we ship with (CASSANDRA-19326). Let's switch to `heap_buffers` here too. WDYT? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org