You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/06/19 01:59:45 UTC

[jira] Created: (HBASE-697) thrift idl needs update to match new 0.2 API

thrift idl needs update to match new 0.2 API
--------------------------------------------

                 Key: HBASE-697
                 URL: https://issues.apache.org/jira/browse/HBASE-697
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: stack
             Fix For: 0.2.0




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Sell updated HBASE-697:
---------------------------

    Attachment: HBASE-697v2.patch

- Added TRowResult.
- Added to ThriftUtilities function for converting RowResult to TRowResult.
- Fixed silly, CopyOfDemoClient from my other patch.
- Updated thrift/package.html


> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, HBASE-697v2.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reassigned HBASE-697:
---------------------------

    Assignee: Tim Sell  (was: Bryan Duxbury)

Assigning Tim.  He fixed it.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Tim Sell
>             Fix For: 0.2.1, 0.3.0
>
>         Attachments: HBASE-697.patch, HBASE-697v2.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622290#action_12622290 ] 

Tim Sell commented on HBASE-697:
--------------------------------

oops I was writing while you were posting. It's pretty much identical to what I did too. Except I was going to replace the existing get functions.
I think H as a prefix should be reserved for stuff part of HBase, rather then thrift stuff.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Toby White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622634#action_12622634 ] 

Toby White commented on HBASE-697:
----------------------------------

>From a brief review, this looks fine to me - but I'm not familiar with most of the HBase API, so don't take my word for it.

Certainly it serves my purposes well enough - I can now retrieve timestamps & delete tables.

A minor thing - the new thrift jar attached requires a newer version of java than I have on this computer (1.5.0_13), but I've run into no problems using the old thrift jar.

As a side issue, I've attached another patch for ThriftServer.java (apply on top of Tim's patch) to HBASE-657, which should probably be rolled into this.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, hbase-timestamps.patch, libthrift-20080411p1.jar
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Toby White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Toby White updated HBASE-697:
-----------------------------

    Affects Version/s: 0.2.0
               Status: Patch Available  (was: Open)

This extends the thrift API to allow retrieval of timestamp information.

A new thrift object is created: HCell, matching HBase's Cell, which is just a (timestamp, value) pair.

Two new methods are added to the thrift Client object: getCells and getCellsTs, which mirror the existing getVer & getVerTs.

The patch is against 0.2.0.

There are also some changes to ThriftServer.java required in order to bring it up to date with latest thrift - these mostly consist of changing ArrayList to List wherever appropriate, all of which is included in the patch. All of the generated files are also changed as a result of using latest thrift, also inside the patch.


> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-697:
------------------------

    Summary: thrift idl needs update/edit to match new 0.2 API (and to fix bugs)  (was: thrift idl needs update to match new 0.2 API)

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614260#action_12614260 ] 

stack commented on HBASE-697:
-----------------------------

Will we just punt this to 0.2.1.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622968#action_12622968 ] 

stack commented on HBASE-697:
-----------------------------

Toby: Any chance of your compiling jar using the facebook 20080411p1 tarball?  It looks like things compile fine but I'm suspicious because a whole package is missing (maybe I need to do more than just do 'an' in lib/java').

Tim: I think a TRowResult will make for less confusion so if you don't mind (scanentry was created before rowresult).  That'd be a nice fixup.  I can do the others no problem.

Thanks

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621533#action_12621533 ] 

stack commented on HBASE-697:
-----------------------------

Here's description of API changes: http://wiki.apache.org/hadoop/Hbase/Plan-0.2/APIChanges.  MIght help figuring what needs fixing.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-697:
------------------------

       Resolution: Fixed
    Fix Version/s: 0.3.0
           Status: Resolved  (was: Patch Available)

Thanks for the patch Tim.  I applied to branch and trunk.   Also added in the new jar built by me using JVM 1.5 against a check out of 20080411p1 (under the lib/java dir).  If it don't work, lets file new issues.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1, 0.3.0
>
>         Attachments: HBASE-697.patch, HBASE-697v2.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623167#action_12623167 ] 

stack commented on HBASE-697:
-----------------------------

Tim: I made issues to cover your suggestions above made at the end of your 'Tim Sell - 14/Aug/08 06:23 AM' comment.


> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1, 0.3.0
>
>         Attachments: HBASE-697.patch, HBASE-697v2.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Sell updated HBASE-697:
---------------------------

    Attachment: libthrift-20080411p1.jar
                HBASE-697.patch

Attached Patch.
Needs review.
If Toby and anyone could look this over and confirm it gives us what we need and conforms to the 0.2 api that would be grand :)

The examples/thrift/DemoClient.java has been updated.

Note, this includes the regenerated thrift files. Importantly I regenerated them using thrift release 20080411p1
which you can get http://developers.facebook.com/thrift/
Thrift is under apache incubation, but the latest stable release is still the last facebook one.

We will need to replace the libthrift jar file with this version. I will attach it for convenience.

There are still some things which could be improved. 
- The new RowLock stuff should be available via thrift. 
- All the non java examples need updating.
- We should really have a junit test covering all of ThriftServer.HBaseHandler.


> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, hbase-timestamps.patch, libthrift-20080411p1.jar
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-697:
------------------------

    Fix Version/s:     (was: 0.2.0)
                   0.2.1
      Description: Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622294#action_12622294 ] 

stack commented on HBASE-697:
-----------------------------

+1 on just replacing the methods that are there currently.
+1 on 'H' as prefix in hbase that doesn't have to show in thrift data structures
+1 on updating thrift (HBASE-822 has gone at least some of the ways).
+1 on TRegionInfo instad of RegionDescriptor
+1 on removing the put methods and using mutateionRow with commit

Thanks Toby and Tim for taking this on.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622307#action_12622307 ] 

Tim Sell commented on HBASE-697:
--------------------------------

Cool, I'll add a patch for the above tomorrow, as soon as I can.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622946#action_12622946 ] 

Tim Sell commented on HBASE-697:
--------------------------------

Hmm, oops the attached libthrift jar might have been compiled on my machine using java 1.6. sorry about that. I'll remove that file.
We should use the jar from facebook.

Stack: Oops, sorry about the CopyOfDemoClient, I guess I lost track of things somewhere. So yes that needs fixing. 
About RowResult, looking over the code again, I realise the RowResult is the analogue of ScanEntry, and this should also be returned for getRow functions (even though we know what row we are getting). ScanEntry should really be called TRowResult I guess. Want me to fix these and stick a new patch up tomorrow?

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622922#action_12622922 ] 

stack commented on HBASE-697:
-----------------------------

Toby: Is it because the jar up on facebook was compiled w/ a 1.6JVM?  I tried downloading and recompiling w/ 1.5 JVM.  Generated jar is suspiciously small.  The content of this package, com/facebook/thrift/processor/, is missing from my built jar.  Agreed that the thing should run w/ a 1.5JVM if that is the issue since rest of hbase is based on 1.5 but I wouldn't put this in way of a commit.

Should I go with Tim's patch and just leave the old thrift jar for now?  That works for you Toby and Tim?

Should  Imake issue to add unit tests for HBaseHandler? IIRC, you don't have to put up thrift servers to exercise this class so should be easy to add.

Tim: Looking at patch, ignoring the generated code (yuck), DemoClient contains a class named 'CopyOfDemoClient'.  Thats a little odd (I can fix on commit if you like).  And you don't have RowResult or a RowResult-like thing in your IDL.  Not needed?  The thrift package.html hasn't been updated (I can do that on commit too).  Otherwise, patch looks great.

Good stuff lads.



> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, hbase-timestamps.patch, libthrift-20080411p1.jar
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Toby White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Toby White updated HBASE-697:
-----------------------------

    Attachment: hbase-timestamps.patch

This is the patch referred to in the previous comment.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623194#action_12623194 ] 

Tim Sell commented on HBASE-697:
--------------------------------

Just want to confirm that with the new libthrift jar it works fine for me.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1, 0.3.0
>
>         Attachments: HBASE-697.patch, HBASE-697v2.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Sell updated HBASE-697:
---------------------------

    Attachment:     (was: libthrift-20080411p1.jar)

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622289#action_12622289 ] 

Tim Sell commented on HBASE-697:
--------------------------------

I've been working on this.
There's a lot of things to update.

Exposing timestamps for cells.
  Change all the get functions to return TCell instead of Bytes and list<Bytes>.
  A TCell would be the thrift version of a Cell. Just as ColumnDescriptor is to HColumnDescriptor.
  with a value and a timestamp field.

Updating to new thrift versions
  Requires the ArrayList's and AbstractMap's to be List and Map. 
  Also the newest libthrift.jar would need to be replaced.

isEnabled, disable enable functions
  Add isTableEnabled function.
  Add enable and disableTable functions. So that a table can actually be deleted.

Fix the examples/thrift/DemoClient.java to match all the changes.

Expose more stuff with RegionDescriptor.
  Add endKey, id, name and version.
  I'm inclined that this should be changed to be called TRegionInfo (to match the Hbase class RegionInfo)

What about the put functions?
  The HTable as per 0.2 does not have put, they must be done through a BatchUpdate.
  The thrift equivalent is mutationRows(table, row, mutations) 
  Do we still want the put functions? Or remove them to match the api?
  They are less cumbersome, they create a BatchUpdate anyway with just a single put.

I wanted to have a patch to pick at today, but I ran out of time.
So comments on just the above?



> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622316#action_12622316 ] 

stack commented on HBASE-697:
-----------------------------

Excellent (Maybe Toby can verify it works?)

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: hbase-timestamps.patch
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-697) thrift idl needs update/edit to match new 0.2 API (and to fix bugs)

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury reassigned HBASE-697:
-----------------------------------

    Assignee: Bryan Duxbury

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.