[GitHub] [beam] nausharipov commented on a diff in pull request #25034: Test loading URLs

[GitBox <gi...@apache.org>]

nausharipov commented on code in PR #25034:
URL: https://github.com/apache/beam/pull/25034#discussion_r1073335908


##########
playground/frontend/playground_components_dev/lib/src/widget_tester.dart:
##########
@@ -50,4 +52,28 @@ extension WidgetTesterExtension on WidgetTester {
     final context = element(find.codeField());
     return context.read<PlaygroundController>();
   }
+
+  Future<void> navigateAndSettle(Uri url) async {
+    print(url);

Review Comment:
   This unnamed print will be hard to find.



##########
playground/frontend/playground_components_dev/lib/src/examples/examples.dart:
##########
@@ -19,17 +19,24 @@
 import 'package:highlight/highlight_core.dart';
 import 'package:http/http.dart' as http;
 
-import 'code.dart';
+import '../code.dart';
 
 class Examples {
-  static const _repoAndBranch = 'apache/beam/master';
+  static const urlPrefix = '$_schemaAndHost$_repoAndBranch';
+  static const _schemaAndHost = 'https://raw.githubusercontent.com/';
+  static const _repoAndBranch = 'akvelon/beam/issue24959_test-loading-url';
+
+  // static const _repoAndBranch = 'apache/beam/master';

Review Comment:
   Is it commented deliberately?



##########
playground/frontend/playground_components_dev/lib/src/widget_tester.dart:
##########
@@ -50,4 +52,28 @@ extension WidgetTesterExtension on WidgetTester {
     final context = element(find.codeField());
     return context.read<PlaygroundController>();
   }
+
+  Future<void> navigateAndSettle(Uri url) async {
+    print(url);
+    await _navigate(url);
+    await Future.delayed(const Duration(seconds:1));

Review Comment:
   `seconds:1` isn't formatted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org