You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/19 15:23:51 UTC

[GitHub] [airflow] raphaelauv commented on a change in pull request #17683: Rename ``none_failed_or_skipped`` by ``none_failed_min_one_success`` trigger rule

raphaelauv commented on a change in pull request #17683:
URL: https://github.com/apache/airflow/pull/17683#discussion_r692223048



##########
File path: airflow/models/baseoperator.py
##########
@@ -551,6 +551,15 @@ def __init__(
             )
             trigger_rule = TriggerRule.ALWAYS
 
+        if trigger_rule == "none_failed_or_skipped":
+            warnings.warn(
+                "none_failed_or_skipped Trigger Rule is deprecated. "
+                "Please use `TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS`.",

Review comment:
       was copying that line https://github.com/apache/airflow/blob/35a6c302772bf5d0bb74646b2da04856c7d7aaac/airflow/models/baseoperator.py#L550  
   
   you remark make sense




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org