You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Yifan Gu <yi...@mesosphere.io> on 2014/07/15 20:00:16 UTC

Review Request 23496: Changed docker.kill() to docker.rm().

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23496/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Timothy Chen.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

Since we actually want to destroy the container, so we need
to delete the container after killing it. We can do this by
calling docker.rm(), which by default does a 'docker rm -f'.


Diffs
-----

  src/slave/containerizer/docker.cpp PRE-CREATION 
  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23496/diff/


Testing
-------

make check


Thanks,

Yifan Gu

Re: Review Request 23496: Changed docker.kill() to docker.rm().

Posted by Yifan Gu <yi...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23496/
-----------------------------------------------------------

(Updated July 17, 2014, 7:40 p.m.)


Review request for mesos, Benjamin Hindman and Timothy Chen.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

Since we actually want to destroy the container, so we need
to delete the container after killing it. We can do this by
calling docker.rm(), which by default does a 'docker rm -f'.


Diffs
-----

  src/slave/containerizer/docker.cpp PRE-CREATION 
  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23496/diff/


Testing
-------

make check


Thanks,

Yifan Gu

Re: Review Request 23496: Changed docker.kill() to docker.rm().

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23496/#review47882
-----------------------------------------------------------


Bad patch!

Reviews applied: [23496]

Failed command: git apply --index 23496.patch

Error:
 error: src/slave/containerizer/docker.cpp: does not exist in index
error: src/tests/docker_containerizer_tests.cpp: does not exist in index


- Mesos ReviewBot


On July 15, 2014, 6 p.m., Yifan Gu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23496/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 6 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy Chen.
> 
> 
> Bugs: MESOS-1524
>     https://issues.apache.org/jira/browse/MESOS-1524
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Since we actually want to destroy the container, so we need
> to delete the container after killing it. We can do this by
> calling docker.rm(), which by default does a 'docker rm -f'.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp PRE-CREATION 
>   src/tests/docker_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23496/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>