You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/14 19:56:16 UTC
[GitHub] [incubator-yunikorn-k8shim] craigcondit opened a new pull request #386: [YUNIKORN-1105] Use absolute units for memory
craigcondit opened a new pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386
### What is this PR for?
Switch to using absolute units (bytes) for memory instead of megabytes (10^6). This avoids rounding errors within the scheduler.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1105
### How should this be tested?
unit tests updated
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1067238855
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#386](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8e58795) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/00cb466bdbe42c89351f83524208d01f13801b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00cb466) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 65.64% 65.65%
=======================================
Files 40 40
Lines 6212 6207 -5
=======================================
- Hits 4078 4075 -3
+ Misses 1979 1977 -2
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <100.00%> (+1.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00cb466...8e58795](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1067238855
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#386](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cd79c0) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/00cb466bdbe42c89351f83524208d01f13801b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00cb466) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 65.64% 65.68% +0.03%
==========================================
Files 40 40
Lines 6212 6207 -5
==========================================
- Hits 4078 4077 -1
+ Misses 1979 1975 -4
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <100.00%> (+1.05%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `85.93% <0.00%> (+1.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00cb466...3cd79c0](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
wilfred-s edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1069966813
With the fix for YUNIKORN-1121 we do not need any changes in `pkg/shim/scheduler_test.go` The tests pass without changes and it shows correctly that the tasks are not seen as _PodQOSBestEffort_ and we can schedule any pod size.
Should we revert the changes for that file from this PR?
Beside that it all looks good, waiting with approval until we decide on the file
EDIT: removed duplicate comment, added missing sentence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1069966813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s removed a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
wilfred-s removed a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1069966827
With the fix for YUNIKORN-1121 we do not need any changes in `pkg/shim/scheduler_test.go` The tests pass without changes and it shows correctly that the tasks are not seen as _PodQOSBestEffort_ and we can schedule any pod size.
Should we revert the changes for that file from this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1067238855
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#386](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cd79c0) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/00cb466bdbe42c89351f83524208d01f13801b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00cb466) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 3cd79c0 differs from pull request most recent head 8e58795. Consider uploading reports for the commit 8e58795 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 65.64% 65.68% +0.03%
==========================================
Files 40 40
Lines 6212 6207 -5
==========================================
- Hits 4078 4077 -1
+ Misses 1979 1975 -4
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <100.00%> (+1.05%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `85.93% <0.00%> (+1.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00cb466...8e58795](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1070378130
Filed a follow up jira to test the `PodQOSBestEffort` in an e2e test [YUNIKORN-1126](https://issues.apache.org/jira/browse/YUNIKORN-1126)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1067238855
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#386](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce5fb67) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/00cb466bdbe42c89351f83524208d01f13801b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00cb466) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 65.64% 65.65%
=======================================
Files 40 40
Lines 6212 6207 -5
=======================================
- Hits 4078 4075 -3
+ Misses 1979 1977 -2
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <100.00%> (+1.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00cb466...ce5fb67](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1067238855
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#386](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cd79c0) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/00cb466bdbe42c89351f83524208d01f13801b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00cb466) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 3cd79c0 differs from pull request most recent head e6e848b. Consider uploading reports for the commit e6e848b to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 65.64% 65.68% +0.03%
==========================================
Files 40 40
Lines 6212 6207 -5
==========================================
- Hits 4078 4077 -1
+ Misses 1979 1975 -4
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <100.00%> (+1.05%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `85.93% <0.00%> (+1.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00cb466...e6e848b](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1067238855
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#386](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce5fb67) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/00cb466bdbe42c89351f83524208d01f13801b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00cb466) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head ce5fb67 differs from pull request most recent head 3cd79c0. Consider uploading reports for the commit 3cd79c0 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 65.64% 65.65%
=======================================
Files 40 40
Lines 6212 6207 -5
=======================================
- Hits 4078 4075 -3
+ Misses 1979 1977 -2
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <100.00%> (+1.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00cb466...3cd79c0](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1067238855
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#386](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cd79c0) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/00cb466bdbe42c89351f83524208d01f13801b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00cb466) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 3cd79c0 differs from pull request most recent head b7e891b. Consider uploading reports for the commit b7e891b to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 65.64% 65.68% +0.03%
==========================================
Files 40 40
Lines 6212 6207 -5
==========================================
- Hits 4078 4077 -1
+ Misses 1979 1975 -4
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <100.00%> (+1.05%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `85.93% <0.00%> (+1.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00cb466...b7e891b](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #386: [YUNIKORN-1105] Use absolute units for memory
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1070308195
> Should we revert the changes for that file from this PR?
Personally I would still keep them, as the new versions are closer to reality. I think the size difference emphasizes that memory is in bytes, and 100 bytes or so as the previous tests used doesn't make much sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org