You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/11 18:22:55 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #22223: Remove deprecated unused option in seed job script

Abacn commented on code in PR #22223:
URL: https://github.com/apache/beam/pull/22223#discussion_r918229860


##########
.test-infra/jenkins/committers_list_generator/main.py:
##########
@@ -63,7 +63,6 @@ def get_committers_github_usernames(ldap_uris, cert_path):
     connection = None
     try:
         ldap.set_option(ldap.OPT_X_TLS_CACERTFILE, cert_path)
-        ldap.set_option(ldap.OPT_X_TLS, ldap.OPT_X_TLS_DEMAND)

Review Comment:
   According to this https://github.com/python-ldap/python-ldap/issues/67 "OPT_X_TLS is deprecated and no longer documented in OpenLDAP: https://www.openldap.org/lists/openldap-software/200409/msg00617.html" (which says "This ldap_set_option(LDAP_OPT_X_TLS) feature is used to explicitly establish an ldaps session. The use of ldaps comes from LDAP version 2 and is deprecated;")
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org