[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1284: refactor(idl): unify the *.thrift files used by cpp and go-client

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1284:
URL: https://github.com/apache/incubator-pegasus/pull/1284#discussion_r1039444988


##########
.github/workflows/lint_and_test_go-client.yml:
##########
@@ -36,27 +36,12 @@ on:
 
 # workflow tasks
 jobs:
-  lint:
-    name: Lint
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          fetch-depth: 1
-      - name: Set up Go
-        uses: actions/setup-go@v2
-        with:
-          go-version: 1.14
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
-        with:
-          version: v1.29
-          working-directory: ./go-client
-
   build:
-    name: Test
-    runs-on: ubuntu-latest
+    name: Test and Lint
+    runs-on: ubuntu:20.04
     steps:
+    - name: Install thrift
+      run: sudo apt-get install -y thrift-compiler

Review Comment:
   Yes, so I specify the runner as ubuntu-20.04, on which the thrift-compiler is 0.13.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org