You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by bw...@apache.org on 2003/06/19 00:35:13 UTC
cvs commit: maven/src/java/org/apache/maven/cli CLIManager.java
bwalding 2003/06/18 15:35:13
Modified: src/java/org/apache/maven/cli CLIManager.java
Log:
Clarifying comments
Revision Changes Path
1.9 +5 -3 maven/src/java/org/apache/maven/cli/CLIManager.java
Index: CLIManager.java
===================================================================
RCS file: /home/cvs/maven/src/java/org/apache/maven/cli/CLIManager.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- CLIManager.java 18 Jun 2003 02:48:08 -0000 1.8
+++ CLIManager.java 18 Jun 2003 22:35:13 -0000 1.9
@@ -94,9 +94,11 @@
options = new Options();
/*
- * XXX the usage here looks broken / confusing.
- * If .create is static, then it can't be using the longopt / description state
- * Which then raises the question, are we misusing OptionBuilder?
+ * Although this looks broken and confusing, it is by design (commons-cli, not ours).
+ * It only presents an issue if this can be called in multiple threads in the
+ * same classloader simultaneously. Which it can't, as this is a static initializer.
+ * The new commons-cli fixes the Builder pattern to work in a better way (OptionBuilder
+ * no longer static).
*/
options.addOption( OptionBuilder
.withLongOpt( "nobanner" )
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org