You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by dk...@apache.org on 2018/02/27 17:18:51 UTC

[40/50] tinkerpop git commit: Minor fixes to Gherkin test docs CTR

Minor fixes to Gherkin test docs CTR


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/eaa14028
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/eaa14028
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/eaa14028

Branch: refs/heads/TINKERPOP-1777
Commit: eaa14028735efbbfb16276e970034106e12c4953
Parents: 90e40e3
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Sat Feb 24 11:52:44 2018 -0500
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Sat Feb 24 11:52:44 2018 -0500

----------------------------------------------------------------------
 docs/src/dev/developer/for-committers.asciidoc | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/eaa14028/docs/src/dev/developer/for-committers.asciidoc
----------------------------------------------------------------------
diff --git a/docs/src/dev/developer/for-committers.asciidoc b/docs/src/dev/developer/for-committers.asciidoc
index 756a522..f5a121c 100644
--- a/docs/src/dev/developer/for-committers.asciidoc
+++ b/docs/src/dev/developer/for-committers.asciidoc
@@ -177,8 +177,7 @@ Test cases for the Gremlin Language currently requires that the newly developed
 
 1. As a test written in Java in the `gremlin-test` module within the subpackages of
 `org.apache.tinkerpop.gremlin.process.traversal.step`
-2. As a test written in Groovy in the `gremlin-groovy-test` module within the same subpackage structure as `gremlin-test`
-3. As a test written in Gherkin in the `gremlin-test` module in the `/features` subdirectory
+2. As a test written in Gherkin in the `gremlin-test` module in the `/features` subdirectory
 
 When writing a Java test case for a Gremlin step, be sure to use the following conventions.
 
@@ -195,14 +194,11 @@ When writing a Java test case for a Gremlin step, be sure to use the following c
 ** `checkResults(Arrays.asList("marko","josh"), traversal)`
 ** `checkMap(new HashMap<String,Long>() {{ put("marko",1l); }}, traversal.next())`
 
-Groovy tests are implemented by extending the Java test and implementing the abstract method that produces the
-traversal. Simply follow existing patterns in those tests - they are self-evident.
-
 Gherkin tests follow some important conventions and have a sub-language that must be adhered to for the tests to
 function properly. Note that Gherkin tests are designed to support the testing of GLVs and at some point will likely
-replace the Java tests (Groovy tests have already been removed in 3.3.x). If a new Java test is added and an associated
-Gherkin tests is not, the overall build will fail the `FeatureCoverageTest` of `gremlin-test` which validates that all
-tests written in Java are also implemented in Gherkin.
+replace the Java tests. If a new Java test is added and an associated Gherkin tests is not, the overall build will
+fail the `FeatureCoverageTest` of `gremlin-test` which validates that all tests written in Java are also implemented
+in Gherkin.
 
 The basic syntax of a Gherkin test is as follows: