[GitHub] [ozone] adoroszlai commented on a diff in pull request #3650: HDDS-7074. DN EndpointStateMachineMBean to add getType()

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3650:
URL: https://github.com/apache/ozone/pull/3650#discussion_r937727613


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/EndpointStateMachine.java:
##########
@@ -341,4 +346,13 @@ public void setLastSuccessfulHeartbeat(
       ZonedDateTime lastSuccessfulHeartbeat) {
     this.lastSuccessfulHeartbeat = lastSuccessfulHeartbeat;
   }
-}
+
+  @Override
+  public String getType() {
+    if (endPoint.getUnderlyingProxyObject()
+            instanceof ReconDatanodeProtocolPB) {
+      return RECONN_TYPE;

Review Comment:
   ```suggestion
         return RECON_TYPE;
   ```



##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/EndpointStateMachine.java:
##########
@@ -56,6 +57,10 @@
   private boolean isPassive;
   private final ExecutorService executorService;
 
+  private static final String RECONN_TYPE = "Reconn";

Review Comment:
   Typo:
   
   ```suggestion
     private static final String RECON_TYPE = "Recon";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org