[jira] [Commented] (ZOOKEEPER-4289) Reduce the performance impact of Prometheus metrics

["Benoit Sigoure (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638309#comment-17638309 ] 

Benoit Sigoure commented on ZOOKEEPER-4289:
-------------------------------------------

The PR is closed on GitHub, should this issue be closed too?

> Reduce the performance impact of Prometheus metrics
> ---------------------------------------------------
>
>                 Key: ZOOKEEPER-4289
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4289
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: metric system
>    Affects Versions: 3.6.3, 3.7.0, 3.6.2, 3.8.0, 3.7.1
>            Reporter: Li Wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.8.1
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> I have done load comparison tests for Prometheus enabled vs disabled and found the performance is reduced about 40%-60% for both read and write operations (i.e. getData, getChildren and createNode). 
> Looked more into this and found that Prometheus Summary is very expensive and there are more than 20 Summary metrics added to the new CommitProcessor.
> Need a solution to reduce the impact of Prometheus metrics.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)