You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/04 07:24:08 UTC

[GitHub] [iceberg] jackye1995 commented on pull request #2520: Core: add key_metadata in ManifestFile

jackye1995 commented on pull request #2520:
URL: https://github.com/apache/iceberg/pull/2520#issuecomment-854435599


   @flyrain thanks for the review! I am marking this as a draft. I spent a few days to figure out the way to go forward with all the changes needed in `ManifestFiles` API and I think I have a plan. I will separate this PR to a few different ones, mainly:
   
   1. adding `keyMetadata` byte array to `ManifestFile` interface and implementation classes.
   2. add support in `EncryptionManager` to decrypt and encrypt by file type
   3. changes to use encryption manager to supply key metadata information down to manifest writer and reader. This will be separated to multiple PRs for core, and engine related changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org