svn commit: r1895017 - /poi/trunk/poi/src/main/java/org/apache/poi/util/RandomSingleton.java

[fa...@apache.org]

Author: fanningpj
Date: Sun Nov 14 10:30:59 2021
New Revision: 1895017

URL: http://svn.apache.org/viewvc?rev=1895017&view=rev
Log:
[github-278] Resolve all SpotBugs P1 issues in Main and Test. Thanks to Andreas Reichel. This closes #278

Added:
    poi/trunk/poi/src/main/java/org/apache/poi/util/RandomSingleton.java   (with props)

Added: poi/trunk/poi/src/main/java/org/apache/poi/util/RandomSingleton.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/util/RandomSingleton.java?rev=1895017&view=auto
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/util/RandomSingleton.java (added)
+++ poi/trunk/poi/src/main/java/org/apache/poi/util/RandomSingleton.java Sun Nov 14 10:30:59 2021
@@ -0,0 +1,19 @@
+package org.apache.poi.util;
+
+import java.security.SecureRandom;
+
+/*
+If it is important that the generated Random numbers not be guessable,
+you MUST NOT create a new Random for each random number; the values are too easily guessable.
+
+You should strongly consider using a java.security.SecureRandom instead
+(and avoid allocating a new SecureRandom for each random number needed).
+*/
+
+public class RandomSingleton {
+    private static final SecureRandom INSTANCE = new SecureRandom();
+
+    public static SecureRandom getInstance() {
+        return INSTANCE;
+    }
+}

Propchange: poi/trunk/poi/src/main/java/org/apache/poi/util/RandomSingleton.java
------------------------------------------------------------------------------
    svn:eol-style = native



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org