[GitHub] [yetus] ndimiduk commented on a diff in pull request #309: YETUS-1230. hadolint is not executable on arm64

["ndimiduk (via GitHub)" <gi...@apache.org>]

ndimiduk commented on code in PR #309:
URL: https://github.com/apache/yetus/pull/309#discussion_r1244773828


##########
precommit/src/main/shell/test-patch-docker/Dockerfile:
##########
@@ -145,14 +145,22 @@ RUN curl -sSL \
 ####
 # Install hadolint (dockerfile lint)
 ####
-FROM yetusbase AS yetushadolint
+FROM yetusbase as yetushadolint_arm64
 ARG HADOLINT_VERSION=2.12.0
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
-RUN if [[ "$(uname -m)" == "x86_64" ]]; then curl -sSL \
-        https://github.com/hadolint/hadolint/releases/download/v$HADOLINT_VERSION/hadolint-Linux-"$(uname -m)" \
+RUN curl -sSl \

Review Comment:
   Can we use `COPY/ADD --link` in place of this embedded curl command? I think it caches better, but requires `docker/dockerfile:1.4` or later. https://docs.docker.com/engine/reference/builder/#copy---link



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org