You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/10/01 00:26:25 UTC
[PR] test(explore): cover color scheme selection, BigNumber subheader/trendline, and WorldMap bubbles [superset]
sadpandajoe opened a new pull request, #44846:
URL: https://github.com/apache/superset/pull/44846
### SUMMARY
The per-visualization Cypress specs stopped running in #36538, once example data moved to YAML and broke their hardcoded dataset and slice ids. They were later deleted as dead code in #40384. This is one of three small PRs that restore the meaningful parts of that coverage at the right tier, rather than re-porting each spec one-to-one.
This PR fills the remaining small unit and RTL gaps:
- **`ColorSchemeControl.test.tsx`**:
- Selecting a scheme calls `onChange` with its id.
- Searching filters the options by label.
- An `isLinear` (sequential) scheme can be selected. The old Cypress color-scheme specs only typed into the search box and never selected an option.
- **BigNumber** (`transformProps.test.ts`, `BigNumberViz.test.tsx`):
- The comparison subheader is omitted when `compareLag` is absent or null, and a configured subheader is kept.
- The trendline is rendered only when `showTrendLine` is true.
- **`WorldMap.test.ts`**: bubbles are drawn when `showBubbles` is true and are absent when it is false. The existing `mockBubbles` was never asserted.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (tests only)
### TESTING INSTRUCTIONS
```bash
cd superset-frontend
npm run test -- src/explore/components/controls/ColorSchemeControl plugins/plugin-chart-echarts/src/BigNumber plugins/plugin-chart-world-map/test
```
Each new test was checked against a mutation of the source it targets, and it fails when that behavior is broken.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(explore): cover color scheme selection, BigNumber subheader/trendline, and WorldMap bubbles [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44846:
URL: https://github.com/apache/superset/pull/44846#issuecomment-5922208300
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(explore): cover color scheme selection, BigNumber subheader/trendline, and WorldMap bubbles [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44846:
URL: https://github.com/apache/superset/pull/44846#issuecomment-5922322001
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44846?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.65%. Comparing base ([`883e43e`](https://app.codecov.io/gh/apache/superset/commit/883e43ee2daca50c92e83d36604f8dd12873434d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09baf1c`](https://app.codecov.io/gh/apache/superset/commit/09baf1cc71eba3aa52a44633e865ea79eecce869?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44846 +/- ##
=======================================
Coverage 81.65% 81.65%
=======================================
Files 2977 2977
Lines 181253 181253
Branches 41873 41873
=======================================
+ Hits 148003 148010 +7
+ Misses 30522 30515 -7
Partials 2728 2728
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44846/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/44846/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.07% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44846?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(explore): cover color scheme selection, BigNumber subheader/trendline, and WorldMap bubbles [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44846:
URL: https://github.com/apache/superset/pull/44846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org