[jira] [Commented] (FLINK-9409) Missing assembly-dependencies in flink-dist/pom.xml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487335#comment-16487335 ] 

ASF GitHub Bot commented on FLINK-9409:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/6064

    [FLINK-9409][mvn] add missing assembly dependencies to flink-dist/pom…

    ## What is the purpose of the change
    
    Building Flink via `mvn clean install -pl flink-dist -am` currently fails because `flink-json` is not defined as a dependency in `flink-dist/pom.xml` although being used in the assembly.
    
    The same is true for `flink-avro` but this seems to be built due to some indirect dependency.
    
    ## Brief change log
    
    - add the following sub-projects to the optional Flink library dependencies in `flink-dist/pom.xml`:
      - `flink-json`
      - `flink-avro`
    
    ## Verifying this change
    
    - build successfully with `mvn clean && mvn install -pl flink-dist -am`
    - checked that `flink-dist_2.11-1.5-SNAPSHOT.jar` is the same as before
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no** (only internally)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-9409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6064
    
----
commit 0e209adc0ea762c7fdb20ac31594376b96a4c01a
Author: Nico Kruber <ni...@...>
Date:   2018-05-22T14:17:52Z

    [FLINK-9409][mvn] add missing assembly dependencies to flink-dist/pom.xml
    
    - flink-json
    - flink-avro

----


> Missing assembly-dependencies in flink-dist/pom.xml
> ---------------------------------------------------
>
>                 Key: FLINK-9409
>                 URL: https://issues.apache.org/jira/browse/FLINK-9409
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>
> Building Flink via {{mvn clean install -pl flink-dist -am}} currently fails because {{flink-json}} is not defined as a dependency in {{flink-dist/pom.xml}} although being used in the assembly.
> The same is true for {{flink-avro}} but this seems to be built due to some indirect dependency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)