You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/10/10 10:00:32 UTC

Review Request 62861: Updated list of excluded files by Python linter.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62861/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.


Repository: mesos


Description
-------

This removes the files that are related to
the C++ linter instead of the Python one.


Diffs
-----

  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62861/diff/1/


Testing
-------

After this commit I have modified 'support/cpplint.py' and checked that it was not linted.


Thanks,

Armand Grillet

Re: Review Request 62861: Updated list of excluded files by Python linter.

Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62861/#review187533
-----------------------------------------------------------


Ship it!




Could you make a similar cleanup for `CppLinter`?

- Benjamin Bannier


On Oct. 10, 2017, noon, Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62861/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, noon)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the files that are related to
> the C++ linter instead of the Python one.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62861/diff/1/
> 
> 
> Testing
> -------
> 
> After this commit I have modified 'support/cpplint.py' and checked that it was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62861: Updated list of excluded files by Python linter.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62861/#review187645
-----------------------------------------------------------



PASS: Mesos patch 62861 was successfully built and tested.

Reviews applied: `['62793', '62861']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62861

- Mesos Reviewbot Windows


On Oct. 10, 2017, 10 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62861/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the files that are related to
> the C++ linter instead of the Python one.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62861/diff/2/
> 
> 
> Testing
> -------
> 
> After this commit I have modified 'support/cpplint.py' and checked that it was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62861: Updated list of excluded files by Python linter.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62861/#review187520
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62793, 62861]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 10, 2017, 10 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62861/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the files that are related to
> the C++ linter instead of the Python one.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62861/diff/1/
> 
> 
> Testing
> -------
> 
> After this commit I have modified 'support/cpplint.py' and checked that it was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62861: Updated list of excluded files by Python linter.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62861/#review187528
-----------------------------------------------------------



PASS: Mesos patch 62861 was successfully built and tested.

Reviews applied: `['62793', '62861']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62861

- Mesos Reviewbot Windows


On Oct. 10, 2017, 10 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62861/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the files that are related to
> the C++ linter instead of the Python one.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62861/diff/1/
> 
> 
> Testing
> -------
> 
> After this commit I have modified 'support/cpplint.py' and checked that it was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62861: Updated list of excluded files by Python linter.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62861/#review195988
-----------------------------------------------------------



Bad review!

Error:
Circular dependency detected for review 62793. Please fix the 'depends_on' field.

- Mesos Reviewbot Windows


On Oct. 10, 2017, 10 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62861/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the files that are related to
> the C++ linter instead of the Python one.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 1b34ea2d9afa8f17b545841cea7a6853a6e18144 
> 
> 
> Diff: https://reviews.apache.org/r/62861/diff/3/
> 
> 
> Testing
> -------
> 
> After this commit I have modified 'support/cpplint.py' and checked that it was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62861: Updated list of excluded files by Python linter.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62861/#review187646
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62793, 62861]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 10, 2017, 10 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62861/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the files that are related to
> the C++ linter instead of the Python one.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62861/diff/2/
> 
> 
> Testing
> -------
> 
> After this commit I have modified 'support/cpplint.py' and checked that it was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>