You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/04/17 04:19:36 UTC
[GitHub] [lucene] gautamworah96 commented on pull request #779: LUCENE-10488: Optimize Facets#getTopDims in IntTaxonomyFacets
gautamworah96 commented on PR #779:
URL: https://github.com/apache/lucene/pull/779#issuecomment-1100800360
I have not taken a detailed look at the PR yet. From the benchmark results posted, I see that we've got a regression in several taxonomy tasks that utilize BInaryDocValues. See (-15, -10, -10, -10). Would you mind re-running the benchmark just to be sure @Yuti-G (also verify that the only difference between mainline and candidate are your commits). Thanks for the effort btw!
```
TaskQPS baseline StdDevQPS candidate StdDev Pct diff p-value
BrowseMonthTaxoFacets 19.31 (43.0%) 16.36 (20.9%) -15.3% ( -55% - 85%) 0.153
BrowseDayOfYearTaxoFacets 17.31 (29.5%) 15.50 (19.3%) -10.4% ( -45% - 54%) 0.186
BrowseDateTaxoFacets 17.15 (29.9%) 15.36 (19.7%) -10.4% ( -46% - 55%) 0.194
BrowseRandomLabelTaxoFacets 14.70 (29.6%) 13.19 (18.5%) -10.3% ( -44% - 53%) 0.189
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org