[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9594: [Fix-9593] Storage Management StorageOperate No Instance

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #9594:
URL: https://github.com/apache/dolphinscheduler/pull/9594#discussion_r853676758


##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteProcessor.java:
##########
@@ -161,7 +163,7 @@ public void process(Channel channel, Command command) {
         }
 
         // submit task to manager
-        boolean offer = workerManager.offer(new TaskExecuteThread(taskExecutionContext, taskCallbackService, alertClientService, taskPluginManager));
+        boolean offer = workerManager.offer(new TaskExecuteThread(taskExecutionContext, taskCallbackService, alertClientService, taskPluginManager, StorageOperateManager.getStorageOperate(ResUploadType.HDFS)));

Review Comment:
   I think we support both `HDFS` and `S3` resources, but in this case, we use HDFS default and without the `S3` type. Should we support `S3` too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org