You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/01 09:38:06 UTC

[GitHub] gianm commented on issue #6014: Optionally refuse to consume new data until the prior chunk is being consumed

gianm commented on issue #6014: Optionally refuse to consume new data until the prior chunk is being consumed
URL: https://github.com/apache/incubator-druid/pull/6014#issuecomment-409515681
 
 
   @drcrallen It's too bad it didn't work out!
   
   > If the DirectDruidClient handler blocked, then the callbacks would not progress and the HttpClient thread would be stalled and risk pool starvation.
   
   I think the issue is that this really can't happen. IIRC, the handlers runs in a Netty async worker pool, and so if it "hogs" the pool for more than a split second, things can come to a screeching halt.
   
   I believe that a workable approach to backpressure must involve cooperation from Netty in some way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org