You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/03/15 11:25:28 UTC
[PR] Remove datafusion-functions-array dependency from datafusion-optimizer [arrow-datafusion]
alamb opened a new pull request, #9621:
URL: https://github.com/apache/arrow-datafusion/pull/9621
## Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/9285
## Rationale for this change
We are trying to decouple the functions from the rest of the system so the core functionality doesn't directly depend on the specific function packages.
## What changes are included in this PR?
1. Remove the explicit dependency on datafusion-functions-array from datafusion-optimizer
2. Port a test to sqllogictests
## Are these changes tested?
Yes
## Are there any user-facing changes?
No (maybe slightly faster compile speeds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Remove datafusion-functions-array dependency from datafusion-optimizer [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #9621:
URL: https://github.com/apache/arrow-datafusion/pull/9621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove datafusion-functions-array dependency from datafusion-optimizer [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #9621:
URL: https://github.com/apache/arrow-datafusion/pull/9621#discussion_r1526143669
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -1257,51 +1255,6 @@ mod test {
Ok(())
}
- #[test]
- fn test_casting_for_fixed_size_list() -> Result<()> {
Review Comment:
I ported this test to `.slt` as it was the only actual use of datafusion_functions_array in this crate
##########
datafusion/optimizer/Cargo.toml:
##########
@@ -45,7 +44,6 @@ async-trait = { workspace = true }
chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-expr = { workspace = true }
-datafusion-functions-array = { workspace = true, optional = true }
Review Comment:
the point of the PR was to remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org