You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Cyrill (via GitHub)" <gi...@apache.org> on 2024/07/16 17:10:39 UTC
[PR] IGNITE-22292 Moved LogSyncer out of Loza and RaftServer. [ignite-3]
Cyrill opened a new pull request, #4094:
URL: https://github.com/apache/ignite-3/pull/4094
https://issues.apache.org/jira/browse/IGNITE-22292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22292 Moved LogSyncer out of Loza and RaftServer. [ignite-3]
Posted by "Cyrill (via GitHub)" <gi...@apache.org>.
Cyrill commented on code in PR #4094:
URL: https://github.com/apache/ignite-3/pull/4094#discussion_r1682387397
##########
modules/raft/src/testFixtures/java/org/apache/ignite/internal/raft/TestLozaFactory.java:
##########
@@ -71,6 +72,30 @@ public static Loza create(
RaftGroupEventsClientListener raftGroupEventsClientListener
) {
LogStorageFactory logStorageFactory = SharedLogStorageFactoryUtils.create(clusterNetSvc.nodeName(), dataPath, raftConfig);
+
+ return create(clusterNetSvc, raftConfig, dataPath, clock, raftGroupEventsClientListener, logStorageFactory);
+ }
+
+ /**
+ * Factory method for {@link Loza}.
+ * Uses the default logStorageFactory, {@link SharedLogStorageFactoryUtils#create(String, Path, RaftConfiguration)},
+ * and automatically wraps it in the Loza instance start/stop methods.
+ *
+ * @param clusterNetSvc Cluster network service.
+ * @param raftConfig Raft configuration.
+ * @param dataPath Data path.
+ * @param clock A hybrid logical clock.
+ * @param raftGroupEventsClientListener Raft group events client listener.
+ * @param logStorageFactory Log storage factory.
+ */
+ public static Loza create(
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22292 Moved LogSyncer out of Loza and RaftServer. [ignite-3]
Posted by "JAkutenshi (via GitHub)" <gi...@apache.org>.
JAkutenshi commented on code in PR #4094:
URL: https://github.com/apache/ignite-3/pull/4094#discussion_r1682253328
##########
modules/raft/src/testFixtures/java/org/apache/ignite/internal/raft/TestLozaFactory.java:
##########
@@ -71,6 +72,30 @@ public static Loza create(
RaftGroupEventsClientListener raftGroupEventsClientListener
) {
LogStorageFactory logStorageFactory = SharedLogStorageFactoryUtils.create(clusterNetSvc.nodeName(), dataPath, raftConfig);
+
+ return create(clusterNetSvc, raftConfig, dataPath, clock, raftGroupEventsClientListener, logStorageFactory);
+ }
+
+ /**
+ * Factory method for {@link Loza}.
+ * Uses the default logStorageFactory, {@link SharedLogStorageFactoryUtils#create(String, Path, RaftConfiguration)},
+ * and automatically wraps it in the Loza instance start/stop methods.
+ *
+ * @param clusterNetSvc Cluster network service.
+ * @param raftConfig Raft configuration.
+ * @param dataPath Data path.
+ * @param clock A hybrid logical clock.
+ * @param raftGroupEventsClientListener Raft group events client listener.
+ * @param logStorageFactory Log storage factory.
+ */
+ public static Loza create(
Review Comment:
Why the separate method with only usage above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22292 Moved LogSyncer out of Loza and RaftServer. [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #4094:
URL: https://github.com/apache/ignite-3/pull/4094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org