[GitHub] [incubator-superset] ktmud commented on a change in pull request #11348: fix: Allow "EXPLAIN" queries when "Allow DML" setting is False

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #11348:
URL: https://github.com/apache/incubator-superset/pull/11348#discussion_r508974919



##########
File path: superset/sql_parse.py
##########
@@ -111,7 +111,18 @@ def is_select(self) -> bool:
         return self._parsed[0].get_type() == "SELECT"
 
     def is_explain(self) -> bool:
-        return self.stripped().upper().startswith("EXPLAIN")
+        # Remove comments
+        statements_without_comments = [
+            statement.strip(" \t\n;")
+            for statement in self.stripped().upper().splitlines()
+            if not statement.startswith("--")
+        ]

Review comment:
       I find it simpler to just use regular expression:
   
   ```python
       queries = re.sub(r'\s*--.*', '', queries)
       queries = [x.strip(' \t\n\r') for x in queries.split(';')]
       queries = [x for x in queries if x]  # query must be non-empty
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org