You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by Dmitriy333 <gi...@git.apache.org> on 2018/04/04 11:18:48 UTC
[GitHub] syncope pull request #:
Github user Dmitriy333 commented on the pull request:
https://github.com/apache/syncope/commit/7b168c142b09c3b03e39f1449211e7ddf026a14d#commitcomment-28411382
In common/lib/src/main/java/org/apache/syncope/common/lib/search/SearchableFields.java:
In common/lib/src/main/java/org/apache/syncope/common/lib/search/SearchableFields.java on line 39:
@ilgrosso , Seems, that it would be great to make `token` field searchable again.
Reset password notification may contain "about" value with a "filter" property.
And "token" field of a "UserTO" may be used in a fiql query of password
reset notification.
E.g. `token!=$null` query can be used as a filter value JPAAnyAbout entity which is a part of JPANotification entity.
If token field is not searchable for UserTO object, then SearchCondVisitor#createAttributeCond(final String schema) creates AttributeCond object instead of AnyCond object, and therefore NotificationManagerImpl skips password reset notification and doesn't process it correctly (look at line 344 in https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/notification/NotificationManagerImpl.java).
FYI, I'm using release version 2.0.8
---