[jira] [Commented] (STORM-2648) Kafka spout can't show acks/fails and complete latency when auto commit is enabled

["Jungtaek Lim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185373#comment-16185373 ] 

Jungtaek Lim commented on STORM-2648:
-------------------------------------

Thanks [~Srdo] for the patch. I merged into master.
Given that target version is is marked as 1.2.0, could you please craft the patch for 1.x branch? I tried to cherry pick but it doesn't looks like a clean cherry-pick.

> Kafka spout can't show acks/fails and complete latency when auto commit is enabled
> ----------------------------------------------------------------------------------
>
>                 Key: STORM-2648
>                 URL: https://issues.apache.org/jira/browse/STORM-2648
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-kafka-client
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>            Reporter: Stig Rohde Døssing
>            Assignee: Stig Rohde Døssing
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> The storm-kafka-client spout currently emits tuples with no message ids if auto commit is enabled. This causes the ack/fail/complete latency counters in Storm UI to be 0. In some cases this is desirable because the user may not care, and doesn't want the overhead of Storm tracking tuples. [~avermeerbergen] expressed a desire to be able to use auto commit without these counters being disabled, presumably to monitor topology performance.
> We should add a toggle that allows users to enable/disable tuple anchoring in the auto commit case. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)