You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2017/05/04 14:34:08 UTC

[3/7] storm git commit: Integrated checkstyle in maven validate phase.Added google java style check

Integrated checkstyle in maven validate phase.Added google java style check


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/8ca135c7
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/8ca135c7
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/8ca135c7

Branch: refs/heads/master
Commit: 8ca135c7f893f8d8975e8ed914e19501f3e0c353
Parents: 2c597e5
Author: vinodkc <vi...@gmail.com>
Authored: Fri Apr 28 10:01:53 2017 +0530
Committer: vinodkc <vi...@gmail.com>
Committed: Tue May 2 22:04:25 2017 +0530

----------------------------------------------------------------------
 pom.xml | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/8ca135c7/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index ac6928b..f814263 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1180,6 +1180,11 @@
         <plugins>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>2.17</version>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
                     <source>1.8</source>
@@ -1187,6 +1192,31 @@
                 </configuration>
             </plugin>
             <plugin>
+                <!--To support checkstyle goals. For example: "mvn checkstyle:checkstyle"-->
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>validate</id>
+                        <phase>validate</phase>
+                        <configuration>
+                            <!--<configLocation>checkstyle/checkstyle.xml</configLocation>-->
+                            <configLocation>google_checks.xml</configLocation>
+                            <encoding>UTF-8</encoding>
+                            <consoleOutput>true</consoleOutput>
+                            <!-- set these values to true after fixing all checkstyle errors -->
+                            <failsOnError>true</failsOnError>
+                            <failOnViolation>true</failOnViolation>
+                            <!--End -->
+                            <violationSeverity>warning</violationSeverity>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-release-plugin</artifactId>
                 <configuration>
@@ -1220,7 +1250,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>2.11</version>
+                <version>2.17</version>
                 <reportSets>
                     <reportSet>
                         <reports>