You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/01 03:14:13 UTC
[GitHub] [spark] ueshin commented on a change in pull request #33876: [SPARK-36626][PYTHON] Support TimestampNTZ in createDataFrame/toPandas and Python UDFs
ueshin commented on a change in pull request #33876:
URL: https://github.com/apache/spark/pull/33876#discussion_r699811451
##########
File path: python/pyspark/sql/pandas/conversion.py
##########
@@ -336,10 +338,12 @@ def createDataFrame(self, data, schema=None, samplingRatio=None, verifySchema=Tr
"has been set to false.\n %s" % str(e))
warnings.warn(msg)
raise
- data = self._convert_from_pandas(data, schema, timezone)
+
+ should_localize = not self._is_timestamp_ntz_preferred()
Review comment:
I mean, I'm just wondering why it's called here.
It can be called earlier to reuse the result, or it can be called later in each function.
##########
File path: python/pyspark/sql/pandas/conversion.py
##########
@@ -336,10 +338,12 @@ def createDataFrame(self, data, schema=None, samplingRatio=None, verifySchema=Tr
"has been set to false.\n %s" % str(e))
warnings.warn(msg)
raise
- data = self._convert_from_pandas(data, schema, timezone)
+
+ should_localize = not self._is_timestamp_ntz_preferred()
Review comment:
nit: we should pass the result of `self._is_timestamp_ntz_preferred()` to `self._create_from_pandas_with_arrow(...)` at line 321 as well to avoid multiple calls?
Otherwise, we can call it in `self._convert_from_pandas(...)` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org