[GitHub] [spark] ulysses-you commented on a change in pull request #33342: [SPARK-35639][SQL][FOLLOWUP] Make hasCoalescedPartition return true if something was actually coalesced

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #33342:
URL: https://github.com/apache/spark/pull/33342#discussion_r669434839



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -92,6 +92,8 @@ case class CustomShuffleReaderExec private(
    */
   def hasCoalescedPartition: Boolean = {
     partitionSpecs.exists {
+      // shuffle from empty RDD
+      case CoalescedPartitionSpec(0, 0, _) => true

Review comment:
       it should be more clearer than `s.startReducerIndex + 1 != s.endReducerIndex`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org