You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/05/30 01:03:00 UTC
[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10538
Change subject: IMPALA-6953: part 1: clean up DiskIoMgr
......................................................................
IMPALA-6953: part 1: clean up DiskIoMgr
There should be no behavioural changes as a result of
this refactoring.
Make DiskQueue an encapsulated class.
Remove friend classes where possible, either by using public
methods or moving code between classes.
Move method into protected in some cases.
Split GetNextRequestRange() into two methods that
operate on DiskQueue and RequestContext state. The methods
belong to the respective classes.
Reduce transitive #include dependencies to hopefully help
with build time.
Testing:
Ran core tests.
Change-Id: I50b448834b832a0ee0dc5d85541691cd2f308e12
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/hdfs-parquet-table-writer.cc
M be/src/exec/hdfs-scan-node-mt.cc
M be/src/exec/hdfs-scan-node-mt.h
M be/src/exec/hdfs-scan-node.h
M be/src/exec/hdfs-scanner.h
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/parquet-column-readers.cc
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr.cc
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/error-converter.cc
M be/src/runtime/io/local-file-system.cc
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/row-batch.h
20 files changed, 590 insertions(+), 533 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/10538/1
--
To view, visit http://gerrit.cloudera.org:8080/10538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50b448834b832a0ee0dc5d85541691cd2f308e12
Gerrit-Change-Number: 10538
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10538 )
Change subject: IMPALA-6953: part 1: clean up DiskIoMgr
......................................................................
IMPALA-6953: part 1: clean up DiskIoMgr
There should be no behavioural changes as a result of
this refactoring.
Make DiskQueue an encapsulated class.
Remove friend classes where possible, either by using public
methods or moving code between classes.
Move method into protected in some cases.
Split GetNextRequestRange() into two methods that
operate on DiskQueue and RequestContext state. The methods
belong to the respective classes.
Reduce transitive #include dependencies to hopefully help
with build time.
Testing:
Ran core tests.
Change-Id: I50b448834b832a0ee0dc5d85541691cd2f308e12
Reviewed-on: http://gerrit.cloudera.org:8080/10538
Reviewed-by: Thomas Marshall <th...@cmu.edu>
Tested-by: Thomas Marshall <th...@cmu.edu>
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/hdfs-parquet-table-writer.cc
M be/src/exec/hdfs-scan-node-mt.cc
M be/src/exec/hdfs-scan-node-mt.h
M be/src/exec/hdfs-scan-node.h
M be/src/exec/hdfs-scanner.h
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/parquet-column-readers.cc
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr.cc
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/error-converter.cc
M be/src/runtime/io/local-file-system.cc
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/row-batch.h
20 files changed, 590 insertions(+), 533 deletions(-)
Approvals:
Thomas Marshall: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I50b448834b832a0ee0dc5d85541691cd2f308e12
Gerrit-Change-Number: 10538
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10538 )
Change subject: IMPALA-6953: part 1: clean up DiskIoMgr
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Cherry-pick, no interesting conflicts, passed gvo: https://jenkins.impala.io/job/gerrit-verify-dryrun/2564/
--
To view, visit http://gerrit.cloudera.org:8080/10538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b448834b832a0ee0dc5d85541691cd2f308e12
Gerrit-Change-Number: 10538
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 May 2018 01:03:36 +0000
Gerrit-HasComments: No