You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:54 UTC

[Impala-CR] Remove dead and untested code 

Hello Internal Jenkins, Dan Hecht,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4232

to review the following change.

Change subject: Remove dead and untested code
......................................................................

Remove dead and untested code

Remove some code that the code coverage build revealed was untested.
It is all dead, aside from SetErrorMsg(), which only had one callsite.

Change-Id: I49c27cbfef03ef97befa9a607b3d8d7ac6e22a43
Reviewed-on: http://gerrit.cloudera.org:8080/3989
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 5ec76c618f50405c154ebe5587b6be5d4f8d234d)
---
M be/src/common/status.h
M be/src/exprs/scalar-fn-call.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/descriptors.cc
M be/src/runtime/descriptors.h
M be/src/runtime/raw-value.cc
M be/src/runtime/raw-value.h
M be/src/service/query-exec-state.h
8 files changed, 2 insertions(+), 220 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/32/4232/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49c27cbfef03ef97befa9a607b3d8d7ac6e22a43
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-CR] Remove dead and untested code

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.

Change subject: Remove dead and untested code
......................................................................


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/4232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I49c27cbfef03ef97befa9a607b3d8d7ac6e22a43
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>