[jira] [Commented] (ARTEMIS-1493) DatabaseStorageConfiguration API is not consistent

["Justin Bertram (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334744#comment-16334744 ] 

Justin Bertram commented on ARTEMIS-1493:
-----------------------------------------

The [underlying JDBC java.sql.Connection#setNetworkTimeout|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#setNetworkTimeout(java.util.concurrent.Executor,%20int)] method which eventually uses this value takes an {{int}}.

> DatabaseStorageConfiguration API is not consistent
> --------------------------------------------------
>
>                 Key: ARTEMIS-1493
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1493
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Jeff Mesnil
>            Priority: Trivial
>
> The setJdbcNetworkTimeout(int jdbcNetworkTimeout) method is not correct. It expects a value in milliseconds but accepts only an int instead of a long.
> The name is also not consistent with the new methods setJdbcLockRenewPeriodMillis(), setJdbcLockExpirationMillis(), setJdbcLockAcquisitionTimeoutMillis() that appends Millis to specify the time unit and accepts long parameters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)