You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2016/08/09 19:16:22 UTC

[Impala-ASF-CR] IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib

Sailesh Mukil has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3872

Change subject: IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib
......................................................................

IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib

TSSLSocketWithWildcardSAN.py was recently added to the impala-shell
as a part of IMPALA-3159. However, it was not exported as a part of
the shell tarball.

This change adds the file to the tarball.

Change-Id: I5a7ab8c20c0b20c21b7f8d008e39c940419e3c4d
---
M shell/make_shell_tarball.sh
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/3872/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a7ab8c20c0b20c21b7f8d008e39c940419e3c4d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib
......................................................................


Patch Set 2: Code-Review+2

> Uploaded patch set 2: Patch Set 1 was rebased.

Rebase, carry +2.

@Henry: Yes, I ran a full build and verified the tarball contents.

-- 
To view, visit http://gerrit.cloudera.org:8080/3872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7ab8c20c0b20c21b7f8d008e39c940419e3c4d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib
......................................................................


IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib

TSSLSocketWithWildcardSAN.py was recently added to the impala-shell
as a part of IMPALA-3159. However, it was not exported as a part of
the shell tarball.

This change adds the file to the tarball.

Change-Id: I5a7ab8c20c0b20c21b7f8d008e39c940419e3c4d
Reviewed-on: http://gerrit.cloudera.org:8080/3872
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Internal Jenkins
---
M shell/make_shell_tarball.sh
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Sailesh Mukil: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a7ab8c20c0b20c21b7f8d008e39c940419e3c4d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib
......................................................................


Patch Set 1: Code-Review+2

Did you check the tarball contents?

-- 
To view, visit http://gerrit.cloudera.org:8080/3872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7ab8c20c0b20c21b7f8d008e39c940419e3c4d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-3965: TSSLSocketWithWildcardSAN.py not exported as part of impala-shell build lib
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7ab8c20c0b20c21b7f8d008e39c940419e3c4d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No