You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "snmvaughan (via GitHub)" <gi...@apache.org> on 2023/02/09 15:23:08 UTC
[GitHub] [arrow-datafusion] snmvaughan opened a new pull request, #5227: Use `_dyn` and `_scalar_dyn` for operations `like`, `ilike`, `nlike`, and `nilike` to support `Dictionary` and `LargeStringArray`
snmvaughan opened a new pull request, #5227:
URL: https://github.com/apache/arrow-datafusion/pull/5227
# Which issue does this PR close?
Closes #5222.
Currently a work in progress that handles the scalar case.
# What changes are included in this PR?
Replaces a simple check for equality with a coercion based check. Replaces `DataType::Utf8` only implementation with the Arrow dyn implementations.
# Are these changes tested?
Existing tests pass. I'll supplement the tests with additional types.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `_dyn` and `_scalar_dyn` for operations `like`, `ilike`, `nlike`, and `nilike` to support `Dictionary` and `LargeStringArray` [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #5227: Use `_dyn` and `_scalar_dyn` for operations `like`, `ilike`, `nlike`, and `nilike` to support `Dictionary` and `LargeStringArray`
URL: https://github.com/apache/arrow-datafusion/pull/5227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5227: Use `_dyn` and `_scalar_dyn` for operations `like`, `ilike`, `nlike`, and `nilike` to support `Dictionary` and `LargeStringArray`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5227:
URL: https://github.com/apache/arrow-datafusion/pull/5227#issuecomment-1475226473
Update here is that `arrow_cast` is now available on main so it should be straightforward to write tests using https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests
Perhaps we could add some tests to
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/predicates.slt
Here is an example of casting an expression to a Dictionary type using
https://github.com/apache/arrow-datafusion/blob/3ccf1aebb6959fbc6bbbf74d2821522ddfd7d484/datafusion/core/tests/sqllogictests/test_files/arrow_typeof.slt#L127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `_dyn` and `_scalar_dyn` for operations `like`, `ilike`, `nlike`, and `nilike` to support `Dictionary` and `LargeStringArray` [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5227:
URL: https://github.com/apache/arrow-datafusion/pull/5227#issuecomment-2043640851
Since this has been open for more than a year, closing it down. Feel free to reopen if/when you keep working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] snmvaughan commented on pull request #5227: Use `_dyn` and `_scalar_dyn` for operations `like`, `ilike`, `nlike`, and `nilike` to support `Dictionary` and `LargeStringArray`
Posted by "snmvaughan (via GitHub)" <gi...@apache.org>.
snmvaughan commented on PR #5227:
URL: https://github.com/apache/arrow-datafusion/pull/5227#issuecomment-1424561785
@comphead Those were the additional tests I planned to add today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5227: Use `_dyn` and `_scalar_dyn` for operations `like`, `ilike`, `nlike`, and `nilike` to support `Dictionary` and `LargeStringArray`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5227:
URL: https://github.com/apache/arrow-datafusion/pull/5227#issuecomment-1454885783
FWIW I am hoping the `arrow_cast` function (from https://github.com/apache/arrow-datafusion/pull/5166) makes it easier to write such tests (as we can we can do it with (only0 SQL)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org