You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@accumulo.apache.org by Srikanth Viswanathan <sr...@gmail.com> on 2015/02/19 19:06:54 UTC

Redundant code in ZKAuthorizor::initializeSecurity ?

There appears to be redundant code in the ZKAuthorizor's
'initializeSecurity' method. It's initializing a bunch of permissions
that are unnecessary in the authorizor. The code seems to have been
replicated from ZKPermHandler. I'd be willing to submit a patch if
someone could confirm that I'm not missing something.

Code in question:

https://github.com/apache/accumulo/blob/master/server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthorizor.java

(lines 87-94 inclusive)

Thanks.

Srikanth

Re: Redundant code in ZKAuthorizor::initializeSecurity ?

Posted by John Vines <vi...@apache.org>.

Yup, they look like they don't belong there.

On Thu, Feb 19, 2015 at 1:06 PM, Srikanth Viswanathan <sr...@gmail.com>
wrote:

> There appears to be redundant code in the ZKAuthorizor's
> 'initializeSecurity' method. It's initializing a bunch of permissions
> that are unnecessary in the authorizor. The code seems to have been
> replicated from ZKPermHandler. I'd be willing to submit a patch if
> someone could confirm that I'm not missing something.
>
> Code in question:
>
>
> https://github.com/apache/accumulo/blob/master/server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthorizor.java
>
> (lines 87-94 inclusive)
>
> Thanks.
>
> Srikanth
>