[jira] [Created] (AVRO-2278) GenericData.Record field getter no correct

["Zoltan Farkas (JIRA)" <ji...@apache.org>]

Zoltan Farkas created AVRO-2278:
-----------------------------------

             Summary: GenericData.Record field getter no correct
                 Key: AVRO-2278
                 URL: https://issues.apache.org/jira/browse/AVRO-2278
             Project: Apache Avro
          Issue Type: Bug
    Affects Versions: 1.8.2
            Reporter: Zoltan Farkas


Currently the get field implementation is not correct in GenericData.Record:

at: https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java#L209

{code}
   @Override public Object get(String key) {
      Field field = schema.getField(key);
      if (field == null) return null;
      return values[field.pos()];
    }
{code}

The method returns null when a field is not present, making it impossible to distinguish between:

field value = null

and

field does not exist.

A more "correct" implementation would be:

{code}
    @Override public Object get(String key) {
      Field field = schema.getField(key);
      if (field == null) {
        throw new IllegalArgumentException("Invalid field " + key);
      }
      return values[field.pos()];
    }
{code}

this will make the behavior consistent with put which will throw a exception when setting a non existent field.

when I make this change in my fork, some bugs in unit tests showed up....




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)