[GitHub] [incubator-hudi] vinothchandar commented on pull request #1484: [HUDI-316] : Hbase qps repartition writestatus

[GitBox <gi...@apache.org>]

vinothchandar commented on pull request #1484:
URL: https://github.com/apache/incubator-hudi/pull/1484#issuecomment-631426244


   @v3nkatesh allow me to give some context around why we are strict around guava.. Hudi as you know has to be dropped under many different services (hive/spark/presto,...) and guava as universal it is, presents a jar conflict nightmare... 
   
   On the re-using code itself, i know we have done this in few places in the past. but, this often leads to maintenance issues more often than not... we change the re-used code, people fix the original code.. and overtime we don't invest in getting upstream bug fixes etc.. So for small stuff like this, I prefer that we write it ourselves.. 
   
   Is this the original [code](https://github.com/google/guava/blob/master/guava/src/com/google/common/util/concurrent/RateLimiter.java) ? I would say if we are trimming down that file and using some parts verbatim, we are still reusing code.. 
   
   The act of adding new things to LICENSE/NOTICE is not that straightforward, given we don't have an entry for guava yet.. We need to examine, guava's NOTICE, its dependencies etc.. I thought, even for you, just writing a small class and being done would be a better use of time? 
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org