You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/22 11:50:49 UTC
[GitHub] [spark] gaborgsomogyi opened a new pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
gaborgsomogyi opened a new pull request #28893:
URL: https://github.com/apache/spark/pull/28893
### What changes were proposed in this pull request?
`OracleIntegrationSuite` is not using the latest oracle JDBC driver. In this PR I've upgraded the driver which supports JDK8, JDK9, and JDK11.
### Why are the changes needed?
Old JDBC driver.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit tests.
Existing integration tests (especially `OracleIntegrationSuite`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647606873
**[Test build #124367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124367/testReport)** for PR 28893 at commit [`1c5525d`](https://github.com/apache/spark/commit/1c5525d277b4b4a99fbd6ddf22ba269859304ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444125198
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
How do you think about that, @maropu ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647982833
@dongjoon-hyun
> During RC vote or automated test, we are testing on the untouched source code.
This justifies the need to fix the hack properly.
I've just double checked your suggestion and seems like I have bad luck because the test consumed ~5 minutes and 3 seconds.
```
20/06/23 00:46:45.940 ScalaTest-run INFO DefaultDockerClient: Starting container with Id: ffb8996e0471656089bdebae35b112e204ceb72487e0bc9099c9d96dda935917
20/06/23 00:51:48.089 ScalaTest-run INFO SharedState: loading hive config file: file:/Users/gaborsomogyi/spark/sql/core/target/scala-2.12/test-classes/hive-site.xml
```
Increasing it to 7 minutes to have some room and avoid flaky behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648084560
**[Test build #124405 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124405/testReport)** for PR 28893 at commit [`b546885`](https://github.com/apache/spark/commit/b5468855ab69f025d45fe73f509c4c021fff80a7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647469245
**[Test build #124364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124364/testReport)** for PR 28893 at commit [`1c5525d`](https://github.com/apache/spark/commit/1c5525d277b4b4a99fbd6ddf22ba269859304ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648040599
Gosh, again this issue:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install (default-cli) on project spark-parent_2.12: ArtifactInstallerException: Failed to install metadata org.apache.spark:spark-parent_2.12/maven-metadata.xml: Could not parse metadata /home/jenkins/.m2/repository/org/apache/spark/spark-parent_2.12/maven-metadata-local.xml: in epilog non whitespace content is not allowed but got > (position: END_TAG seen ...</metadata>\n>... @13:2) -> [Help 1]
```
Retrying after lunch...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444088394
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -155,7 +155,7 @@ abstract class DockerJDBCIntegrationSuite extends SharedSparkSession with Eventu
docker.startContainer(containerId)
jdbcUrl = db.getJdbcUrl(dockerIp, externalPort)
var conn: Connection = null
- eventually(timeout(2.minutes), interval(1.second)) {
+ eventually(timeout(7.minutes), interval(1.second)) {
Review comment:
On the way...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648085727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647469770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647986143
**[Test build #124405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124405/testReport)** for PR 28893 at commit [`b546885`](https://github.com/apache/spark/commit/b5468855ab69f025d45fe73f509c4c021fff80a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444075984
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -155,7 +155,7 @@ abstract class DockerJDBCIntegrationSuite extends SharedSparkSession with Eventu
docker.startContainer(containerId)
jdbcUrl = db.getJdbcUrl(dockerIp, externalPort)
var conn: Connection = null
- eventually(timeout(2.minutes), interval(1.second)) {
+ eventually(timeout(7.minutes), interval(1.second)) {
Review comment:
@gaborgsomogyi . `7 minutes` is okay. But, it seems that you misunderstand my PR. You can use more higher values, but you should not increase the timeout of the other test suites. Please see my PR. I keep `2.minutes` for all the other test suite and only allow longer timeout for `OracleIntegrationSuite`.
- https://github.com/gaborgsomogyi/spark/pull/2/files#diff-bf03588f75a2d7b55214924fd611e528R99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648032030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647709438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444099556
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -155,7 +155,7 @@ abstract class DockerJDBCIntegrationSuite extends SharedSparkSession with Eventu
docker.startContainer(containerId)
jdbcUrl = db.getJdbcUrl(dockerIp, externalPort)
var conn: Connection = null
- eventually(timeout(2.minutes), interval(1.second)) {
+ eventually(timeout(7.minutes), interval(1.second)) {
Review comment:
Thanks. Ya. During review, I didn't update my original comment. My bad. I should be more clear on the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647606873
**[Test build #124367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124367/testReport)** for PR 28893 at commit [`1c5525d`](https://github.com/apache/spark/commit/1c5525d277b4b4a99fbd6ddf22ba269859304ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647986786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648035031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647986143
**[Test build #124405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124405/testReport)** for PR 28893 at commit [`b546885`](https://github.com/apache/spark/commit/b5468855ab69f025d45fe73f509c4c021fff80a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647605470
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647468611
cc @gatorsmile @dongjoon-hyun @maropu @MaxGekk to pull everybody in who helps in https://github.com/apache/spark/pull/28863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444131501
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
Ah, I see. Looks okay now. Thanks, @dongjoon-hyun and @gaborgsomogyi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647561873
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648030796
**[Test build #124412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124412/testReport)** for PR 28893 at commit [`e56e02b`](https://github.com/apache/spark/commit/e56e02b0fc17f10c071222fddc5dd1c91d810c0a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647607550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648035703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648034543
**[Test build #124413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124413/testReport)** for PR 28893 at commit [`e56e02b`](https://github.com/apache/spark/commit/e56e02b0fc17f10c071222fddc5dd1c91d810c0a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647469770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444099556
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -155,7 +155,7 @@ abstract class DockerJDBCIntegrationSuite extends SharedSparkSession with Eventu
docker.startContainer(containerId)
jdbcUrl = db.getJdbcUrl(dockerIp, externalPort)
var conn: Connection = null
- eventually(timeout(2.minutes), interval(1.second)) {
+ eventually(timeout(7.minutes), interval(1.second)) {
Review comment:
Thanks. Ya. During review, I didn't update the original comment. My bad. I should be more clear on the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647959551
Thanks for the work, @gaborfeher !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648034543
**[Test build #124413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124413/testReport)** for PR 28893 at commit [`e56e02b`](https://github.com/apache/spark/commit/e56e02b0fc17f10c071222fddc5dd1c91d810c0a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647708290
**[Test build #124367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124367/testReport)** for PR 28893 at commit [`1c5525d`](https://github.com/apache/spark/commit/1c5525d277b4b4a99fbd6ddf22ba269859304ece).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444094020
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -155,7 +155,7 @@ abstract class DockerJDBCIntegrationSuite extends SharedSparkSession with Eventu
docker.startContainer(containerId)
jdbcUrl = db.getJdbcUrl(dockerIp, externalPort)
var conn: Connection = null
- eventually(timeout(2.minutes), interval(1.second)) {
+ eventually(timeout(7.minutes), interval(1.second)) {
Review comment:
Hmmm, just read back the situation. [Here](https://github.com/apache/spark/pull/28893#discussion_r443809246) I've read 5 minutes what I've thought is a bit small so changed the code manually. Just seen your effort which contains 10 minutes :) Sorry...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444124690
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
For this one, I believe it's okay because now we have all SQL drivers in one place. In this root pom, we have MySQL/Maria/PostgreSQL/DB2/MsSqlServer already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444036845
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
This change is questionable but I think rolling this back and adding it in the next commit ends-up more work nominally. Apart from that purely personal taste but I like the dependency management way of dep handling (even if only one reference exists).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r443809246
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
##########
@@ -31,27 +31,30 @@ import org.apache.spark.sql.types._
import org.apache.spark.tags.DockerTest
/**
- * This patch was tested using the Oracle docker. Created this integration suite for the same.
- * The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository. Since there was
- * no jdbc jar available in the maven repository, the jar was downloaded from oracle site
- * manually and installed in the local; thus tested. So, for SparkQA test case run, the
- * ojdbc jar might be manually placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0)
- * while Spark QA test run.
- *
* The following would be the steps to test this
* 1. Build Oracle database in Docker, please refer below link about how to.
* https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md
* 2. export ORACLE_DOCKER_IMAGE_NAME=$ORACLE_DOCKER_IMAGE_NAME
* Pull oracle $ORACLE_DOCKER_IMAGE_NAME image - docker pull $ORACLE_DOCKER_IMAGE_NAME
* 3. Start docker - sudo service docker start
- * 4. Download oracle 11g driver jar and put it in maven local repo:
- * (com/oracle/ojdbc6/11.2.0.2.0/ojdbc6-11.2.0.2.0.jar)
- * 5. The timeout and interval parameter to be increased from 60,1 to a high value for oracle test
- * in DockerJDBCIntegrationSuite.scala (Locally tested with 200,200 and executed successfully).
- * 6. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite"
+ * 4. The timeout and interval parameter to be increased to a high value for oracle test in
+ * DockerJDBCIntegrationSuite.scala (Locally tested with 20 min timeout and 1 sec interval
+ * then executed successfully).
Review comment:
After repeating some, `5 minutes` seems sufficient in some cases. Or, we can introduction a new val or def `connectionTimeout`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647773787
I made a PR to you. Could you review and consider that?
- https://github.com/gaborgsomogyi/spark/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r443809246
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
##########
@@ -31,27 +31,30 @@ import org.apache.spark.sql.types._
import org.apache.spark.tags.DockerTest
/**
- * This patch was tested using the Oracle docker. Created this integration suite for the same.
- * The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository. Since there was
- * no jdbc jar available in the maven repository, the jar was downloaded from oracle site
- * manually and installed in the local; thus tested. So, for SparkQA test case run, the
- * ojdbc jar might be manually placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0)
- * while Spark QA test run.
- *
* The following would be the steps to test this
* 1. Build Oracle database in Docker, please refer below link about how to.
* https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md
* 2. export ORACLE_DOCKER_IMAGE_NAME=$ORACLE_DOCKER_IMAGE_NAME
* Pull oracle $ORACLE_DOCKER_IMAGE_NAME image - docker pull $ORACLE_DOCKER_IMAGE_NAME
* 3. Start docker - sudo service docker start
- * 4. Download oracle 11g driver jar and put it in maven local repo:
- * (com/oracle/ojdbc6/11.2.0.2.0/ojdbc6-11.2.0.2.0.jar)
- * 5. The timeout and interval parameter to be increased from 60,1 to a high value for oracle test
- * in DockerJDBCIntegrationSuite.scala (Locally tested with 200,200 and executed successfully).
- * 6. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite"
+ * 4. The timeout and interval parameter to be increased to a high value for oracle test in
+ * DockerJDBCIntegrationSuite.scala (Locally tested with 20 min timeout and 1 sec interval
+ * then executed successfully).
Review comment:
`20 min` looks like a magic number. After repeating some, `5 minutes` seems sufficient in some cases.
Or, we can introduction a new val or def `connectionTimeout`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647561045
**[Test build #124364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124364/testReport)** for PR 28893 at commit [`1c5525d`](https://github.com/apache/spark/commit/1c5525d277b4b4a99fbd6ddf22ba269859304ece).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r443809246
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
##########
@@ -31,27 +31,30 @@ import org.apache.spark.sql.types._
import org.apache.spark.tags.DockerTest
/**
- * This patch was tested using the Oracle docker. Created this integration suite for the same.
- * The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository. Since there was
- * no jdbc jar available in the maven repository, the jar was downloaded from oracle site
- * manually and installed in the local; thus tested. So, for SparkQA test case run, the
- * ojdbc jar might be manually placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0)
- * while Spark QA test run.
- *
* The following would be the steps to test this
* 1. Build Oracle database in Docker, please refer below link about how to.
* https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md
* 2. export ORACLE_DOCKER_IMAGE_NAME=$ORACLE_DOCKER_IMAGE_NAME
* Pull oracle $ORACLE_DOCKER_IMAGE_NAME image - docker pull $ORACLE_DOCKER_IMAGE_NAME
* 3. Start docker - sudo service docker start
- * 4. Download oracle 11g driver jar and put it in maven local repo:
- * (com/oracle/ojdbc6/11.2.0.2.0/ojdbc6-11.2.0.2.0.jar)
- * 5. The timeout and interval parameter to be increased from 60,1 to a high value for oracle test
- * in DockerJDBCIntegrationSuite.scala (Locally tested with 200,200 and executed successfully).
- * 6. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite"
+ * 4. The timeout and interval parameter to be increased to a high value for oracle test in
+ * DockerJDBCIntegrationSuite.scala (Locally tested with 20 min timeout and 1 sec interval
+ * then executed successfully).
Review comment:
After repeating some, `5 minutes` seems sufficient. So, we need to bump from `2 minutes` to `5 minutes`. Or, we can introduction a new val or def `connectionTimeout`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648032030
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444084912
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
Honestly not considered independency but I agree with the direction. I would like to understand your point but not yet able. Here we're considering on which side the dep management will be. We can consider dep management change as an additional complexity at the top of the actual code base. If we move that from this PR into the other one will make this more independent but on the other side will make the other one less independent. I see this as a tradeoff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444084912
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
Honestly not considered independency but I agree with the direction. I would like to understand your point but not yet able. here we're considering on which side the dep management will be. We can consider dep management change as an additional complexity at the top of the actual code base. If we move that from this PR into the other one will make this more independent but on the other side will make the other one less independent. I see this as a tradeoff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444039218
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
##########
@@ -31,27 +31,30 @@ import org.apache.spark.sql.types._
import org.apache.spark.tags.DockerTest
/**
- * This patch was tested using the Oracle docker. Created this integration suite for the same.
- * The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository. Since there was
- * no jdbc jar available in the maven repository, the jar was downloaded from oracle site
- * manually and installed in the local; thus tested. So, for SparkQA test case run, the
- * ojdbc jar might be manually placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0)
- * while Spark QA test run.
- *
* The following would be the steps to test this
* 1. Build Oracle database in Docker, please refer below link about how to.
* https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md
* 2. export ORACLE_DOCKER_IMAGE_NAME=$ORACLE_DOCKER_IMAGE_NAME
* Pull oracle $ORACLE_DOCKER_IMAGE_NAME image - docker pull $ORACLE_DOCKER_IMAGE_NAME
* 3. Start docker - sudo service docker start
- * 4. Download oracle 11g driver jar and put it in maven local repo:
- * (com/oracle/ojdbc6/11.2.0.2.0/ojdbc6-11.2.0.2.0.jar)
- * 5. The timeout and interval parameter to be increased from 60,1 to a high value for oracle test
- * in DockerJDBCIntegrationSuite.scala (Locally tested with 200,200 and executed successfully).
- * 6. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite"
+ * 4. The timeout and interval parameter to be increased to a high value for oracle test in
+ * DockerJDBCIntegrationSuite.scala (Locally tested with 20 min timeout and 1 sec interval
+ * then executed successfully).
Review comment:
Yeah, it's magically high enough not to cause issues. I personally would not add further complexity but just increase the timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648035031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444075984
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -155,7 +155,7 @@ abstract class DockerJDBCIntegrationSuite extends SharedSparkSession with Eventu
docker.startContainer(containerId)
jdbcUrl = db.getJdbcUrl(dockerIp, externalPort)
var conn: Connection = null
- eventually(timeout(2.minutes), interval(1.second)) {
+ eventually(timeout(7.minutes), interval(1.second)) {
Review comment:
@gaborgsomogyi . `7 minutes` is okay for `Oracle` suite. But, it seems that you misunderstand my PR. You can use more higher values, but you should not increase the timeout of the other test suites. Please see my PR. I keep `2.minutes` for all the other test suite and only allow longer timeout for `OracleIntegrationSuite`.
- https://github.com/gaborgsomogyi/spark/pull/2/files#diff-bf03588f75a2d7b55214924fd611e528R99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647561873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647607550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647709438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648032020
**[Test build #124412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124412/testReport)** for PR 28893 at commit [`e56e02b`](https://github.com/apache/spark/commit/e56e02b0fc17f10c071222fddc5dd1c91d810c0a).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648090885
Just arrived back and seen the status.
Thank you @dongjoon-hyun and @maropu for all the efforts!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647606899
Filed SPARK-32054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648085727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648035710
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124413/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648035690
**[Test build #124413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124413/testReport)** for PR 28893 at commit [`e56e02b`](https://github.com/apache/spark/commit/e56e02b0fc17f10c071222fddc5dd1c91d810c0a).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647561887
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124364/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647469245
**[Test build #124364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124364/testReport)** for PR 28893 at commit [`1c5525d`](https://github.com/apache/spark/commit/1c5525d277b4b4a99fbd6ddf22ba269859304ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648030796
**[Test build #124412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124412/testReport)** for PR 28893 at commit [`e56e02b`](https://github.com/apache/spark/commit/e56e02b0fc17f10c071222fddc5dd1c91d810c0a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444161537
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
Thank you guys for the clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647986786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648035703
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborfeher commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborfeher commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647985288
> Thanks for the work, @gaborfeher !
Other Gabor :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444121671
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
> but on the other side will make the other one less independent.
You meant #28863 can avoid the dependency for this oracle driver in the root pom? I thought you added the dependency in #28863 for adding some secure connector's tests in the `core` package:
https://github.com/apache/spark/pull/28863/files#diff-0b713a218f4e99665e339404f7b6c6c3R153-R157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648032038
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124412/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444013421
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
We need to update this root pom in this PR? It seems this change is related to the ohter PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28893:
URL: https://github.com/apache/spark/pull/28893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648033211
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648027862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-648027862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #28893: [SPARK-32049][SQL]Upgrade oracle JDBC driver to the latest
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #28893:
URL: https://github.com/apache/spark/pull/28893#issuecomment-647467849
I've just re-executed `OracleIntegrationSuite` on my local Mac and passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444047604
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
hm, but, if this PR is reverted for some reason after the two PRs have been merged, will the other PR break? I think each PR should be as independent as possible for backports/reverts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org