You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/21 12:28:48 UTC

[GitHub] [apisix-website] SkyeYoung commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation

SkyeYoung commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133616891

   > > Can you fix the formatting problem first? 😆
   > 
   > Oh, i'm sorry, because I set up my Vscode editor config:
   > 
   > ```json
   > {
   >   "editor.formatOnSave": true,
   >   "[javascript]": {
   >     "editor.defaultFormatter": "esbenp.prettier-vscode"
   >   },
   >   "[typescriptreact]": {
   >     "editor.defaultFormatter": "vscode.typescript-language-features"
   >   },
   >   "[json]": {
   >     "editor.defaultFormatter": "esbenp.prettier-vscode"
   >   }
   > }
   > ```
   > 
   > what formatting tool do you use, can you recommend me?
   
   We are using eslint, although it is not strictly a formatting tool. For some reason I don't use strict configuration, so it has a lot of problems. If you follow the readme I wrote and install the appropriate dependencies, eslint should help you with some of the formatting issues by husky calling it before you commit. If there are some deficiencies or problems with our configuration, you are welcome to help us improve it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org