[jira] [Commented] (CB-9762) App icon and Launch image for iPad Pro

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455280#comment-15455280 ] 

ASF GitHub Bot commented on CB-9762:
------------------------------------

GitHub user kerrishotts opened a pull request:

    https://github.com/apache/cordova-ios/pull/250

    CB-9762 (iOS) Add launch storyboard support

    - [X] Signed ICLA
    - [X] Jira Issue: [CB-9762](https://issues.apache.org/jira/browse/CB-9762)
    - [X] Tests:
        - [X] Automated (npm test; all passing)  Note: no automated tests for this functionality, though
        - [X] Manual (with and without launch storyboard images):
            - iPhone 6s (iOS 10b8)
            - iPad Pro (iOS 10b8)
    
    Note: The splashscreen plugin will require updating to use the new images; but I think that should be a separate (but related) issue. I don't think it will be difficult to add though (crossing my fingers)!
    
    Note: Documentation will need to be updated to reflect the changes in this PR
    
    Note: No default splash images are provided; they would be overwritten anyway upon
    adding the platform. I've added the images I used below:
    
    ![default 2x universal anyany](https://cloud.githubusercontent.com/assets/164498/18167642/545814e8-7017-11e6-8b55-8f24e412ca70.png)
    ![default 2x universal comany](https://cloud.githubusercontent.com/assets/164498/18167643/547aa1ac-7017-11e6-8334-86598ed1afd3.png)
    ![default 2x universal comcom](https://cloud.githubusercontent.com/assets/164498/18167644/547b1dda-7017-11e6-888b-ada91b8572a1.png)
    ![default 3x universal anycom](https://cloud.githubusercontent.com/assets/164498/18167645/547e5bbc-7017-11e6-9665-dff978bff0aa.png)
    ![default 3x universal comany](https://cloud.githubusercontent.com/assets/164498/18167646/54828070-7017-11e6-9bce-63de89bfd406.png)
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kerrishotts/cordova-ios CB-9762

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #250
    
----
commit 12eb374e93987a260dce57b5be1acbe1279a61e1
Author: Kerri Shotts <ke...@gmail.com>
Date:   2016-08-24T22:49:20Z

    CB-9762 Add launch storyboard support
    
    NB: No default splash images are provided; they would be overwritten anyway upon
    adding the platform.

----


> App icon and Launch image for iPad Pro
> --------------------------------------
>
>                 Key: CB-9762
>                 URL: https://issues.apache.org/jira/browse/CB-9762
>             Project: Apache Cordova
>          Issue Type: Task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: iOS
>    Affects Versions: 4.0.0
>            Reporter: Manuel Martiarena
>            Assignee: Kerri Shotts
>              Labels: cordova-ios-4.1.1
>         Attachments: Default-Landscape@2x~ipad-pro.png, Default-Portrait@2x~ipad-pro.png
>
>
> Provide app icon image and launch image for iPad Pro
> iPad Pro (@2x) App icon required 167x167
> iPad Pro (@2x) Launch image required 2048 x 2732 (portrait)
> 2732 x 2048 (landscape)
> https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org