You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/23 22:44:07 UTC
[GitHub] [pulsar-site] Paul-TT opened a new pull request #6: config and style updates
Paul-TT opened a new pull request #6:
URL: https://github.com/apache/pulsar-site/pull/6
I left some config updates out of my previous pull request. I also corrected a few styles that were pointed out to me.
I added the sineWaves import back to the index.js file because it was failing without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace merged pull request #6: config and style updates
Posted by GitBox <gi...@apache.org>.
urfreespace merged pull request #6:
URL: https://github.com/apache/pulsar-site/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace commented on a change in pull request #6: config and style updates
Posted by GitBox <gi...@apache.org>.
urfreespace commented on a change in pull request #6:
URL: https://github.com/apache/pulsar-site/pull/6#discussion_r814436861
##########
File path: site2/website-next/src/pages/index.js
##########
@@ -1,4 +1,5 @@
-import React, { useEffect, componentDidMount } from "react";
+import React, { useEffect } from "react";
+import SineWaves from "sine-waves";
Review comment:
@Paul-TT It looks like you haven't merge the latest changes to your `PR`, please merge the `main` branch into your branch and then submit your `PR`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace commented on a change in pull request #6: config and style updates
Posted by GitBox <gi...@apache.org>.
urfreespace commented on a change in pull request #6:
URL: https://github.com/apache/pulsar-site/pull/6#discussion_r814412578
##########
File path: site2/website-next/src/pages/index.js
##########
@@ -129,7 +130,13 @@ export default function Home() {
];
useEffect((d) => {
startWaves();
-
+ var winW = window.outerWidth;
Review comment:
we can't use `window` directly because the buiding is based on `SSR`, you can have a test by `npm run build`, maybe this `https://docusaurus.io/docs/docusaurus-core#useIsBrowser` can help @Paul-TT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org